Check grants for databases in case of renaming databases#40906
Merged
nikitamikhaylov merged 5 commits intomasterfrom Sep 5, 2022
Merged
Check grants for databases in case of renaming databases#40906nikitamikhaylov merged 5 commits intomasterfrom
nikitamikhaylov merged 5 commits intomasterfrom
Conversation
nikitamikhaylov
commented
Sep 1, 2022
Member
Author
There was a problem hiding this comment.
This may be unneeded, because I copy-pasted the test
Member
There was a problem hiding this comment.
no-parallel tag can be avoided by using unique database and user name, it's quite easy to do in .sh test:
${CLICKHOUSE_CLIENT} --multiline --multiquery -q """
DROP DATABASE IF EXISTS database_02416_${CLICKHOUSE_DATABASE};
CREATE DATABASE database_02416__${CLICKHOUSE_DATABASE};
DROP USER IF EXISTS user_test_02416__${CLICKHOUSE_DATABASE};
CREATE USER user_test_02416__${CLICKHOUSE_DATABASE} IDENTIFIED WITH plaintext_password BY 'user_test_02416';
tavplubix
approved these changes
Sep 2, 2022
Comment on lines
185
to
189
Member
There was a problem hiding this comment.
We don't have EXCHANGE DATABASES query
df588ae to
89f8604
Compare
fanqi1909
pushed a commit
to ByConity/ByConity
that referenced
this pull request
May 8, 2024
fix(clickhousech@m-3594234201): cp fix from ClickHouse/ClickHouse#40906 See merge request: https://code.byted.org/dp/ClickHouse/merge_requests/21501
liyinsg
added a commit
to liyinsg/ByConity
that referenced
this pull request
Jun 19, 2024
dogauzuncukoglu
pushed a commit
to edgedelta/ByConity
that referenced
this pull request
Jul 28, 2024
fix(clickhousech@m-3594234201): cp fix from ClickHouse/ClickHouse#40906 See merge request: https://code.byted.org/dp/ClickHouse/merge_requests/21501
dogauzuncukoglu
pushed a commit
to edgedelta/ByConity
that referenced
this pull request
Jul 28, 2024
fix(clickhousech@m-3594234201): cp fix from ClickHouse/ClickHouse#40906 See merge request: https://code.byted.org/dp/ClickHouse/merge_requests/21501
dogauzuncukoglu
pushed a commit
to edgedelta/ByConity
that referenced
this pull request
Jul 28, 2024
fix(clickhousech@m-3594234201): cp fix from ClickHouse/ClickHouse#40906 See merge request: https://code.byted.org/dp/ClickHouse/merge_requests/21501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed a behaviour when user with explicitly revoked grant for dropping databases can still drop it.