Fix for exponential time decaying window functions#36944
Merged
novikd merged 5 commits intoClickHouse:masterfrom Jun 7, 2022
Merged
Fix for exponential time decaying window functions#36944novikd merged 5 commits intoClickHouse:masterfrom
novikd merged 5 commits intoClickHouse:masterfrom
Conversation
novikd
reviewed
Jun 3, 2022
Comment on lines
1597
to
1598
Member
There was a problem hiding this comment.
Suggested change
| auto * const state = static_cast<State *>(static_cast<void *>(place)); | |
| *state = State(); | |
| new (place) State(); |
Member
There was a problem hiding this comment.
Why do you inherit WindowFunctionHelpers?
Contributor
Author
There was a problem hiding this comment.
Yes, it's not needed.
novikd
approved these changes
Jun 3, 2022
edf7c68 to
c8cae1d
Compare
novikd
approved these changes
Jun 3, 2022
| { | ||
| Float64 last_max = getLastValueFromState<Float64>(transform, function_index, STATE_MAX); | ||
| Float64 last_t = getLastValueFromInputColumn<Float64>(transform, function_index, ARGUMENT_TIME); | ||
| Float64 result = -std::numeric_limits<Float64>::infinity(); |
Member
There was a problem hiding this comment.
Suggested change
| Float64 result = -std::numeric_limits<Float64>::infinity(); | |
| Float64 result = std::numeric_limits<Float64>::lowest(); |
Member
|
Failures are unrelated. |
excitoon
pushed a commit
to excitoon-favorites/ClickHouse
that referenced
this pull request
Jun 24, 2022
…p_smooth Fix for exponential time decaying window functions
This was referenced Jun 24, 2022
excitoon
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jun 24, 2022
excitoon
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jun 27, 2022
excitoon
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jul 14, 2022
arthurpassos
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Jul 15, 2022
Window functions and GCP fixes ClickHouse#36944, ClickHouse#34632, ClickHouse#37659 and ClickHouse#37882
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jul 28, 2022
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jul 28, 2022
Window functions and GCP fixes ClickHouse#36944, ClickHouse#34632, ClickHouse#37659 and ClickHouse#37882
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Aug 4, 2022
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Aug 4, 2022
Window functions and GCP fixes ClickHouse#36944, ClickHouse#34632, ClickHouse#37659 and ClickHouse#37882
This was referenced Aug 4, 2022
4 tasks
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Sep 13, 2022
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Sep 17, 2022
…4632, ClickHouse#37659 and ClickHouse#37882 Merge pull request ClickHouse#36944 from excitoon-favorites/better_exp_smooth Merge pull request ClickHouse#34632 from excitoon-favorites/optimizedprocessing Merge pull request ClickHouse#37659 from frew/master Support `batch_delete` capability for GCS Merge pull request ClickHouse#37882 from excitoon-favorites/nodeleteobjects Fixes for objects removal in `S3ObjectStorage`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix for exponential time decaying window functions. Now respecting boundaries of the window.