Conversation
|
|
alesapin
reviewed
Mar 26, 2022
Member
alesapin
left a comment
There was a problem hiding this comment.
Actually I'm not sure that we have to support all data types as arguments... Maybe leave only integers Everything will be faster and simpler :)
src/Functions/makeDate.cpp
Outdated
| if (converted_argument_type->equals(*argument_type)) | ||
| converted_arguments.push_back(argument_column); | ||
| else if (isNumber(argument_type)) | ||
| converted_arguments.push_back(convert_to_number_func.executeImpl( |
Member
There was a problem hiding this comment.
Not the most effective way, but for such function it shouldn't be a problem at all.
Member
Author
There was a problem hiding this comment.
replaced my custom conversion logic to castColumn() that is used in other similar cases
alesapin
approved these changes
Mar 29, 2022
Member
|
Let's add it to category "New feature" and add Changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added functions makeDate(year, month, day), makeDate32(year, month, day)