Skip to content

Fix SHOW GRANTS when partial revokes are used.#31249

Merged
Avogar merged 1 commit intoClickHouse:masterfrom
vitlibar:fix-show-grants
Nov 12, 2021
Merged

Fix SHOW GRANTS when partial revokes are used.#31249
Avogar merged 1 commit intoClickHouse:masterfrom
vitlibar:fix-show-grants

Conversation

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar vitlibar commented Nov 10, 2021

Changelog category:

  • Bug Fix

Changelog entry:
Fix SHOW GRANTS when partial revokes are used. This PR fixes #31138

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 10, 2021
@Avogar Avogar self-assigned this Nov 10, 2021
@Avogar
Copy link
Copy Markdown
Member

Avogar commented Nov 12, 2021

@vitlibar Can you look at failed Functional stateless tests flaky check?

@vitlibar
Copy link
Copy Markdown
Member Author

vitlibar commented Nov 12, 2021 •
edited
Loading

@vitlibar Can you look at failed Functional stateless tests flaky check?

It failed because the test creates some user (named test_user_01073) and the flaky check runs multiple instances of the test in multiple threads in parallel, so for the second run the user already exists and thus all those runs except the first one fail. I think we can just ignore that, it must not become a problem in master.

@Avogar Avogar merged commit 051a9e7 into ClickHouse:master Nov 12, 2021
This was referenced Nov 12, 2021
Closed
Merged
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Nov 12, 2021
Backport #31249 to 21.8: Fix SHOW GRANTS when partial revokes are used.
912c0d7
@robot-clickhouse robot-clickhouse mentioned this pull request Nov 12, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Nov 12, 2021
Backport #31249 to 21.10: Fix SHOW GRANTS when partial revokes are used.
526d00c
@robot-clickhouse robot-clickhouse mentioned this pull request Nov 12, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Nov 12, 2021
Backport #31249 to 21.11: Fix SHOW GRANTS when partial revokes are used.
3d891f2
@robot-clickhouse robot-clickhouse mentioned this pull request Nov 12, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Nov 12, 2021
Backport #31249 to 21.9: Fix SHOW GRANTS when partial revokes are used.
386e391
@robot-clickhouse robot-clickhouse mentioned this pull request Nov 12, 2021
Merged
Avogar added a commit that referenced this pull request Nov 15, 2021
@Avogar
Merge pull request #31371 from ClickHouse/backport/21.9/31249
0bb4732 
Backport #31249 to 21.9: Fix SHOW GRANTS when partial revokes are used.
Avogar added a commit that referenced this pull request Nov 15, 2021
@Avogar
Merge pull request #31370 from ClickHouse/backport/21.11/31249
0c36d3d 
Backport #31249 to 21.11: Fix SHOW GRANTS when partial revokes are used.
Avogar added a commit that referenced this pull request Nov 15, 2021
@Avogar
Merge pull request #31369 from ClickHouse/backport/21.10/31249
fb6fe27 
Backport #31249 to 21.10: Fix SHOW GRANTS when partial revokes are used.
Avogar added a commit that referenced this pull request Nov 15, 2021
@Avogar
Merge pull request #31368 from ClickHouse/backport/21.8/31249
396529d 
Backport #31249 to 21.8: Fix SHOW GRANTS when partial revokes are used.
@vitlibar vitlibar deleted the fix-show-grants branch November 17, 2021 15:35
vitlibar pushed a commit that referenced this pull request Nov 17, 2021
@Avogar
Merge pull request #31249 from vitlibar/fix-show-grants
e23af21 
Fix SHOW GRANTS when partial revokes are used.

(cherry picked from commit 051a9e7)
liyinsg added a commit to liyinsg/ByConity that referenced this pull request Jun 19, 2024
@liyinsg
Fix SHOW GRANTS when partial revokes are used
98be6ad 
See merge request: ClickHouse/ClickHouse#31249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REVOKE SELECT on another table alters order of applying GRANTS

3 participants

@vitlibar @Avogar @robot-clickhouse