Skip to content

Disable write with AIO even for big merges#18481

Merged
alexey-milovidov merged 3 commits intomasterfrom
disable_write_with_aio
Dec 25, 2020
Merged

Disable write with AIO even for big merges#18481
alexey-milovidov merged 3 commits intomasterfrom
disable_write_with_aio

Conversation

@alesapin
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Disable write with AIO during merges because it can lead to extremely rare data corruption of primary key columns during merge.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Dec 24, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member

Fuzzer: #18492

@alexey-milovidov
Copy link
Copy Markdown
Member

Flaky test fixed in #18493.

@alexey-milovidov alexey-milovidov merged commit 491f481 into master Dec 25, 2020
@alexey-milovidov alexey-milovidov deleted the disable_write_with_aio branch December 25, 2020 01:24
tavplubix pushed a commit that referenced this pull request Dec 25, 2020
Disable write with AIO even for big merges

(cherry picked from commit 491f481)
alesapin added a commit that referenced this pull request Dec 25, 2020
Backport #18481 to 20.11: Disable write with AIO even for big merges
alesapin added a commit that referenced this pull request Dec 25, 2020
Backport #18481 to 20.10: Disable write with AIO even for big merges
alesapin added a commit that referenced this pull request Dec 25, 2020
Backport #18481 to 20.12: Disable write with AIO even for big merges
alexey-milovidov added a commit that referenced this pull request Dec 26, 2020
Backport #18481 to 20.9: Disable write with AIO even for big merges
alesapin added a commit that referenced this pull request Feb 18, 2021
…fbe779f10a7c2ae6f36fe8bd4a47e

Cherry pick #18481 to 20.8: Disable write with AIO even for big merges
alesapin added a commit that referenced this pull request Feb 19, 2021
Backport #18481 to 20.8: Disable write with AIO even for big merges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants