ASTTableIdentifier Part #1: improve internal representation of ASTIdentifier name#16149
Merged
abyss7 merged 9 commits intoClickHouse:masterfrom Oct 24, 2020
Merged
ASTTableIdentifier Part #1: improve internal representation of ASTIdentifier name#16149abyss7 merged 9 commits intoClickHouse:masterfrom
abyss7 merged 9 commits intoClickHouse:masterfrom
Conversation
Contributor
Author
|
Yandex third-party fixed |
tavplubix
approved these changes
Oct 23, 2020
Comment on lines
+178
to
+179
| std::vector<String> parts = {column_name}; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| std::vector<String> parts = {column_name}; | |
| std::vector<String> parts; |
Comment on lines
+181
to
+182
| if (!table_name.empty()) parts.insert(parts.begin(), table_name); | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| if (!table_name.empty()) parts.insert(parts.begin(), table_name); | |
| if (!table_name.empty()) | |
| parts.push_back(std::move(table_name)); | |
| parts.push_back(column_name); |
traceon
added a commit
to traceon/ClickHouse
that referenced
this pull request
Oct 26, 2020
* master: (285 commits) Update uuid-functions.md Revert "Revert "Optionally upload clickhouse binary in fast test"" DOCSUP-2806: Add meta header in RU (ClickHouse#15801) DOCSUP-3200: Edit and translate to Russian (ClickHouse#16204) Update cloud.md Fix trash Fixing another issue in LDAP tests. Fixing procedure of getting log file size in LDAP tests. Increasing default timeouts. Remove message broker pool from context Fix async Distributed INSERT w/ prefer_localhost_replica=0 and internal_replication UUID safe cast functions added Links fixed. Text updated ant translated to Russian Improve performance of FunctionsLogical a little by adding "restrict" Check style Remove excessive exclamation marks Fix performance test "functions logical" after move to clang Remove flaky LIVE VIEW test ASTTableIdentifier Part #1: improve internal representation of ASTIdentifier name (ClickHouse#16149) Update ThreadStatusExt.cpp ... # Conflicts: # programs/local/LocalServer.cpp # src/Server/HTTPHandler.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Use only |name_parts| as primary name source and auto-generate full name