Ensure resource destruction order in ReadFromStorageStep.#15645
Merged
KochetovNicolai merged 2 commits intomasterfrom Oct 6, 2020
Merged
Ensure resource destruction order in ReadFromStorageStep.#15645KochetovNicolai merged 2 commits intomasterfrom
KochetovNicolai merged 2 commits intomasterfrom
Conversation
Akazz
reviewed
Oct 6, 2020
Member
Author
|
fuzzer is reported here: #15683 |
This was referenced Oct 6, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 7, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 7, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 7, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 7, 2020
KochetovNicolai
added a commit
that referenced
this pull request
Oct 7, 2020
Backport #15645 to 20.9: Ensure resource destruction order in ReadFromStorageStep.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 7, 2020
Backport #15645 to 20.8: Ensure resource destruction order in ReadFromStorageStep.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 7, 2020
Backport #15645 to 20.7: Ensure resource destruction order in ReadFromStorageStep.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 7, 2020
Backport #15645 to 20.6: Ensure resource destruction order in ReadFromStorageStep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the order of destruction for resources in
ReadFromStoragestep of query plan. It might cause crashes in rare cases. Possibly connected with #15610.