Don't throw exception if Distributed storage has multi-volume storage policy configuration#14839
Conversation
… policy configuration.
|
The same test passed in release mode. Seems it's just flaky. Moreover, no changes related to ReplicatedMergeTree have made. |
|
We have not observed failures of this test before. |
|
The change is obvious and should not introduce this error. |
|
Yes, seems like this test is flaky. |
|
Where did you specify the default storage policy? I thought it's at least in merge_tree_storage settings section which won't affect Distributed engines. I also hit related issues and proposed #13573 |
… has multi-volume storage policy configuration
… has multi-volume storage policy configuration
… has multi-volume storage policy configuration
You can declare |
But it should not be applied for the StorageDistributed, since it uses storages only if the 5 argument is passed Oh, I see this has been changed in #12670 (and it is kind of interesting, f5af645, the commit message and the undocumented behavior changes, cc @excitoon ), although it wasn't the intention at the beginning - #8756 |
Backport #14839 to 20.8: Don't throw exception if Distributed storage has multi-volume storage policy configuration
Backport #14839 to 20.9: Don't throw exception if Distributed storage has multi-volume storage policy configuration
Backport #14839 to 20.7: Don't throw exception if Distributed storage has multi-volume storage policy configuration
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow using multi-volume storage configuration in storage Distributed.
Detailed description / Documentation draft:
If a user has a default storage policy with multi-volume configuration he can create MergeTree storages, but can't create Distributed storage. Such behavior worsens UX, and even more multi-volume configuration doesn't make practical sense. Second and other volumes in such configuration will be ignored for storage Distributed.