Correct nullability checker for LowCardinality nested columns#14591
Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom Sep 9, 2020
myrrc:bugfix/lc-nullability-checker
Merged
Correct nullability checker for LowCardinality nested columns#14591alexey-milovidov merged 4 commits intoClickHouse:masterfrom myrrc:bugfix/lc-nullability-checker
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
myrrc:bugfix/lc-nullability-checker
Conversation
Contributor
Author
|
Related: #14590 |
Member
|
Maybe add a test? |
alexey-milovidov
approved these changes
Sep 9, 2020
Member
|
It's 100% green. Let's add a specific test (to make sure it won't be introduced later) and merge after fast test check. |
This was referenced Sep 9, 2020
Closed
Merged
Merged
alexey-milovidov
added a commit
that referenced
this pull request
Sep 10, 2020
Backport #14591 to 20.8: Correct nullability checker for LowCardinality nested columns
alexey-milovidov
added a commit
that referenced
this pull request
Sep 14, 2020
Backport #14591 to 20.9: Correct nullability checker for LowCardinality nested columns
Member
|
The message for changelog is not actually useful. |
Member
|
I write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added the checker as neither calling
lc->isNullable()nor callingls->getDictionaryPtr()->isNullable()would return the correct result.