Fix segfault in combinator -Resample#14562
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Sep 8, 2020
Merged
Fix segfault in combinator -Resample#14562alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
Member
Author
|
Probably there are some places in code with the same mistake. |
Member
Broken integration test @vzakaznikov |
alexey-milovidov
approved these changes
Sep 8, 2020
This was referenced Sep 8, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 8, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 8, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 8, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 8, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Sep 9, 2020
Backport #14562 to 20.6: Fix segfault in combinator -Resample
alexey-milovidov
added a commit
that referenced
this pull request
Sep 9, 2020
Backport #14562 to 20.9: Fix segfault in combinator -Resample
alexey-milovidov
added a commit
that referenced
this pull request
Sep 9, 2020
Backport #14562 to 20.8: Fix segfault in combinator -Resample
alexey-milovidov
added a commit
that referenced
this pull request
Sep 9, 2020
Backport #14562 to 20.7: Fix segfault in combinator -Resample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix rare segfaults in functions with combinator -Resample, which could appear in result of overflow with very large parameters.
Fixes #14537.