Add tag pass for integration base image. Add explicit dns options for docker-compose.#14323
Merged
qoega merged 7 commits intoClickHouse:masterfrom Sep 3, 2020
Merged
Add tag pass for integration base image. Add explicit dns options for docker-compose.#14323qoega merged 7 commits intoClickHouse:masterfrom
qoega merged 7 commits intoClickHouse:masterfrom
Conversation
alesapin
approved these changes
Sep 3, 2020
Member
alesapin
left a comment
There was a problem hiding this comment.
LGTM, CI already passes tag to this image.
Member
|
Most likely this PR broke integration tests: And #14440 |
This was referenced Sep 4, 2020
Closed
Merged
Merged
alesapin
pushed a commit
that referenced
this pull request
Oct 8, 2020
Add tag pass for integration base image. Add explicit dns options for docker-compose. (cherry picked from commit 2b8ad57)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Detailed description / Documentation draft:
Add tag pass for integration base image. Add explicit dns options for docker-compose.
Added logs in DNSCacheUpdater.
By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.
Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/