Skip to content

Fix "There is no supertype" error on ALTER UPDATE #7306#12633

Merged
alexey-milovidov merged 1 commit intomasterfrom
alter-update-cast
Jul 22, 2020
Merged

Fix "There is no supertype" error on ALTER UPDATE #7306#12633
alexey-milovidov merged 1 commit intomasterfrom
alter-update-cast

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jul 21, 2020

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Exception There is no supertype... can be thrown during ALTER ... UPDATE in unexpected cases (e.g. when subtracting from UInt64 column). This fixes #7306. This fixes #4165.

Detailed description / Documentation draft:
I remember that we have recently added a setting cast_keep_nullable #11733. This may lead to trouble. Need to check it.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Jul 21, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member Author

cast_keep_nullable is not pushed to mutations interpreter, so we are safe unless this setting is modified globally.

@alesapin alesapin self-assigned this Jul 21, 2020
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-milovidov alexey-milovidov merged commit c91c860 into master Jul 22, 2020
@alexey-milovidov alexey-milovidov deleted the alter-update-cast branch July 22, 2020 05:05
alexey-milovidov added a commit that referenced this pull request Jul 23, 2020
Backport #12633 to 20.6: Fix "There is no supertype" error on ALTER UPDATE #7306
alexey-milovidov added a commit that referenced this pull request Jul 27, 2020
Backport #12633 to 20.3: Fix "There is no supertype" error on ALTER UPDATE #7306
alexey-milovidov added a commit that referenced this pull request Jul 27, 2020
Backport #12633 to 20.4: Fix "There is no supertype" error on ALTER UPDATE #7306
alexey-milovidov added a commit that referenced this pull request Jul 27, 2020
Backport #12633 to 20.5: Fix "There is no supertype" error on ALTER UPDATE #7306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is no supertype for types UInt64, Int64 when using alter table update alter update behaviour depends on where (can fail with DB::Exception)

3 participants