Return non-Nullable results from COUNT(DISTINCT), more complete.#11661
Merged
alexey-milovidov merged 10 commits intomasterfrom Jun 17, 2020
Merged
Return non-Nullable results from COUNT(DISTINCT), more complete.#11661alexey-milovidov merged 10 commits intomasterfrom
alexey-milovidov merged 10 commits intomasterfrom
Conversation
0491ff5 to
217d054
Compare
…m:yandex/ClickHouse into return-not-nullable-from-count-distinct-2
Member
Author
|
This PR is also notable because we will augment all factories with documentation in similar way |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jun 17, 2020
The following error reported:
FAILED: src/Interpreters/tests/hash_map
...
ld.lld: error: undefined symbol: typeinfo for DB::AggregateFunctionCount
>>> referenced by typeinfo:308 (../contrib/libcxx/include/typeinfo:308)
>>> InterpreterSelectQuery.cpp.o:(std::__1::enable_if<is_pointer_v<DB::AggregateFunctionCount*>, DB::AggregateFunctionCount*>::type typeid_cast<DB::AggregateFunctionCount*, DB::IAggregateFunction>(DB::IAggregateFunction*)) in archive src/libdbms.a
collect2: error: ld returned 1 exit status
And also this one with gold linker:
FAILED: programs/clickhouse-odbc-bridge
... src/AggregateFunctions/libclickhouse_aggregate_functions.a ... src/libdbms.a ...
../contrib/libcxx/include/typeinfo:308: error: undefined reference to 'typeinfo for DB::AggregateFunctionCount'
Due to order?
Introduced by 394fb64/ClickHouse#11661 I guess.
This was referenced Oct 14, 2020
Closed
This was referenced Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Return non-Nullable result from COUNT(DISTINCT), and
uniqaggregate functions family. If all passed values are NULL, return zero instead. This improves SQL compatibility.Detailed description / Documentation draft:
It is better than #11593, because if all arguments are NULL literals, we return 0.