Fix visitParamExtractRaw for strings with unbalanced { or [.#11318
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom May 31, 2020
Merged
Fix visitParamExtractRaw for strings with unbalanced { or [.#11318alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
Member
|
Ok. All tests have passed.
Actually it's Ok (false positive). Some queries continue to run in background for 10 seconds, and the fail happeded due to test order randomization. Will fix it in our infrastructure. |
Member
It's flacky test, #11320
Actually it's OOM on our test machine. |
alexey-milovidov
approved these changes
May 31, 2020
alexey-milovidov
added a commit
that referenced
this pull request
May 31, 2020
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix visitParamExtractRaw for strings with unbalanced { or [.
(cherry picked from commit 5b2b373)
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix visitParamExtractRaw for strings with unbalanced { or [.
(cherry picked from commit 5b2b373)
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix visitParamExtractRaw for strings with unbalanced { or [.
(cherry picked from commit 5b2b373)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11254 .
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix visitParamExtractRaw when extracted JSON has strings with unbalanced { or [.