Merged
Conversation
Contributor
Author
|
This is more of a quick fix, and in the long run we need to have structured error messages (like error/context/hint in postgres), and scoped error hints. |
4ertus2
reviewed
May 20, 2020
akuzm
commented
May 22, 2020
3a60637 to
09129a6
Compare
4ertus2
approved these changes
May 26, 2020
akuzm
added a commit
that referenced
this pull request
Jul 10, 2020
Better error messages about joins (cherry picked from commit 4b1bb43)
akuzm
added a commit
that referenced
this pull request
Jul 14, 2020
* [wip] add fmtlib to 20.3 * Merge pull request #11446 from ClickHouse/aku/better-error-messages Improve error messages (cherry picked from commit 7db8edf) * fixup * Merge pull request #11076 from ClickHouse/aku/join-error-messages Better error messages about joins (cherry picked from commit 4b1bb43)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imagine having a multi-statement query of a couple hundred lines, and then getting an error:
or
That's it, no more info, good luck with re-reading your entire query line by line.
This PR adds the offending subselect or the list of tables joined with USING to the error message, making it easier to locate the error.
Changelog category (leave one):