Skip to content

Native Common Virtuals for FileLog#101006

Merged
Michicosun merged 6 commits intomasterfrom
native_common_virtuals/FileLog
Mar 31, 2026
Merged

Native Common Virtuals for FileLog#101006
Michicosun merged 6 commits intomasterfrom
native_common_virtuals/FileLog

Conversation

@Michicosun
Copy link
Copy Markdown
Member

@Michicosun Michicosun commented Mar 28, 2026

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Part of #100766

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 28, 2026 •
edited
Loading

Workflow [PR], commit [1145c4e]

Summary: ❌

job_name test_name status info comment
Stress test (arm_debug) failure
Possible deadlock on shutdown (see gdb.log) FAIL cidb
Upgrade check (amd_release) failure
Error message in clickhouse-server.log (see upgrade_error_messages.txt) FAIL cidb

AI Review

Summary

This PR makes _table a native virtual column for FileLog and updates common virtual-column handling to derive from each storage's current virtual-column snapshot, so _table is not duplicated. I did not find new correctness, safety, compatibility, or performance issues in the final PR state.

Missing context
  • ⚠️ CI is still in progress (Style check, Code Review, Fast test, Build (arm_tidy)), so there is no final completed CI signal yet.
ClickHouse Rules
Item Status Notes
Deletion logging ➖
Serialization versioning ➖
Core-area scrutiny ✅
No test removal ✅
Experimental gate ➖
No magic constants ✅
Backward compatibility ✅
SettingsChangesHistory.cpp ➖
PR metadata quality ✅
Safe rollout ✅
Compilation time ✅
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 28, 2026
clickhouse-gh[bot]
clickhouse-gh bot reviewed Mar 29, 2026
View reviewed changes
clickhouse-gh[bot]
clickhouse-gh bot reviewed Mar 29, 2026
View reviewed changes
@groeneai groeneai mentioned this pull request Mar 30, 2026
Open
@yariks5s yariks5s self-assigned this Mar 30, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 30, 2026

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.10% 84.20% +0.10%
Functions 90.90% 90.90% +0.00%
Branches 76.70% 76.70% +0.00%

Changed lines: 87.90% (138/157) · Uncovered code

Full report · Diff report

@Michicosun Michicosun added this pull request to the merge queue Mar 31, 2026
Merged via the queue into master with commit 6626971 Mar 31, 2026
161 of 164 checks passed
@Michicosun Michicosun deleted the native_common_virtuals/FileLog branch March 31, 2026 12:06
clickgapai added a commit to clickgapai/ClickHouse that referenced this pull request Mar 31, 2026
@clickgapai
Add 1 test(s) for coverage gaps in PR ClickHouse#101006
1bf848c
@clickgapai clickgapai mentioned this pull request Mar 31, 2026
Closed
1 task
@clickgapai
Copy link
Copy Markdown
Contributor

clickgapai commented Mar 31, 2026

Hi @Michicosun @yariks5s — while reviewing this PR I found the following:

Could you review the test PR and add the can be tested label if it looks good?
Happy to discuss — close anything that's wrong or already addressed.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clickhouse-gh clickhouse-gh[bot] clickhouse-gh[bot] left review comments

@yariks5s yariks5s yariks5s approved these changes

Assignees

@yariks5s yariks5s

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Michicosun @clickgapai @yariks5s @robot-clickhouse-ci-2