Open
Conversation
The `APPLE` condition was disabling the embedded compiler (JIT) and DWARF parser on macOS. The comment only explains the MSAN exclusion, and the Apple exclusion appears to be a leftover from early days when LLVM didn't build cleanly on macOS. Remove it to enable JIT on macOS by default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [90251dc] Summary: ❌
AI ReviewSummaryThis PR removes the legacy ClickHouse Rules
Final Verdict
|
When cross-compiling to macOS, LLVM's `config-ix.cmake` detects `HAVE_LIBRT` from the Linux build host, but `librt` doesn't exist on macOS. The LLVM Orc JIT libraries (`LLVMOrcTargetProcess`, `LLVMOrcJIT`, `LLVMOrcDebugging`) link `rt` when `HAVE_LIBRT` is set, causing: `ld: library not found for -lrt`. Fix by setting `HAVE_LIBRT` to false for Apple targets before entering the LLVM subdirectory. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=100947&sha=98ea2118ba286f3973765cc477b882e5ecd12080&name_0=PR&name_1=Build%20%28amd_darwin%29 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexey-milovidov
added a commit
that referenced
this pull request
Mar 29, 2026
…es than `skip_first_lines` When `input_format_csv_skip_first_lines` or `input_format_tsv_skip_first_lines` is set to a value larger than the number of lines in the file, `skipPrefixBeforeHeader` enters an infinite loop doing `pread` at EOF. Each call to `readRow` succeeds with an empty result even at EOF, so the loop never terminates. Add an EOF check before each `readRow` call to break out of the loop when the file is exhausted. Found via AST fuzzer in Stress test (amd_msan) on PR #100947. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Algunenano
approved these changes
Mar 30, 2026
Member
Algunenano
left a comment
There was a problem hiding this comment.
Seems to work fine:
:) SELECT
COUNT()
FROM
jit_test
WHERE
NOT ignore(a / b + c / d + e / f + g / h + i / j)
SETTINGS
compile_expressions = 0;
SELECT COUNT()
FROM jit_test
WHERE NOT ignore(((((a / b) + (c / d)) + (e / f)) + (g / h)) + (i / j))
SETTINGS compile_expressions = 0
Query id: 4d9b1028-d3aa-483b-a93a-2c682b905323
┌───COUNT()─┐
1. │ 200000000 │ -- 200.00 million
└───────────┘
1 row in set. Elapsed: 1.774 sec. Processed 190.86 million rows, 15.27 GB (107.58 million rows/s., 8.61 GB/s.)
Peak memory usage: 294.53 KiB.
:) SELECT
COUNT()
FROM
jit_test
WHERE
NOT ignore(a / b + c / d + e / f + g / h + i / j)
SETTINGS
compile_expressions = 1,
min_count_to_compile_expression = 1
SELECT COUNT()
FROM jit_test
WHERE NOT ignore(((((a / b) + (c / d)) + (e / f)) + (g / h)) + (i / j))
SETTINGS compile_expressions = 1, min_count_to_compile_expression = 1
Query id: e05cbfe2-85d5-4a6f-85af-3f8c9315eb23
┌───COUNT()─┐
1. │ 200000000 │ -- 200.00 million
└───────────┘
1 row in set. Elapsed: 0.211 sec. Processed 200.00 million rows, 16.00 GB (949.12 million rows/s., 75.93 GB/s.)
Peak memory usage: 295.34 KiB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
APPLEcondition was disabling the embedded compiler (JIT) and DWARF parser on macOS. The comment only explains the MSAN exclusion, and the Apple exclusion appears to be a leftover from early days when LLVM didn't build cleanly on macOS. Remove it to enable JIT on macOS by default.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Enable JIT compilation on macOS.
Documentation entry for user-facing changes