tests: better fix for 03706_statistics_preserve_checksums_on_mutations#100896
Merged
azat merged 1 commit intoClickHouse:masterfrom Mar 27, 2026
Merged
Conversation
The previous bot attempt was to set serialization_info_version='basic',
while this is OK, it is not transparent what was the problem.
Let's instead set map_serialization_version='basic',
map_serialization_version_for_zero_level_parts='basic', since those was
causes the difference:
File: .server/data/default/mt/all_1_1_0_2/serialization.json
{"columns":[],"propagate_types_serialization_versions_to_nested_types":true,"types_serialization_versions":{"nullable":1,"string":0},"version":1}
File: .server/data/default/mt/all_1_1_0/serialization.json
{"columns":[],"propagate_types_serialization_versions_to_nested_types":true,"types_serialization_versions":{"map":1,"nullable":1,"string":0},"version":1}
1 task
Contributor
|
Workflow [PR], commit [ee5b389] Summary: ❌
AI ReviewSummaryThis PR updates the stateless test ClickHouse Rules
Final Verdict
|
1 task
Member
|
Interesting how we can use it to make the cat better. FYI @pufit |
Algunenano
approved these changes
Mar 27, 2026
Merged
via the queue into
ClickHouse:master
with commit Mar 27, 2026
d1c68a3
151 of 153 checks passed
Desel72
pushed a commit
to Desel72/ClickHouse
that referenced
this pull request
Mar 30, 2026
…_preserve_checksums_on_mutations tests: better fix for 03706_statistics_preserve_checksums_on_mutations
This was referenced Mar 31, 2026
groeneai
added a commit
to groeneai/ClickHouse
that referenced
this pull request
Apr 2, 2026
Re-add serialization_info_version='basic' pin that was mistakenly removed in PR ClickHouse#100896. The original fix in PR ClickHouse#100772 correctly identified that serialization_info_version='with_types' causes checksum mismatches between INSERT and mutation paths due to different serialization.json metadata content. PR ClickHouse#100896 replaced this pin with map_serialization_version pins, but that addressed a different issue. After ClickHouse#100896 merged, master failures returned at ~1-3/day (32 master failures in 14 days across all CI build types). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous bot attempt (#100772) was to set serialization_info_version='basic', while this is OK, it is not transparent what was the problem.
Let's instead set map_serialization_version='basic', map_serialization_version_for_zero_level_parts='basic', since those was causes the difference:
Changelog category (leave one):