Backport #99483 to 26.2: Fix heap-use-after-free in MergeTreeReadTask::createReaders#100855
Merged
Conversation
…::createReaders
Contributor
|
Workflow [BackportPR], commit [462f13b] Summary: ❌
|
groeneai
added a commit
to groeneai/ClickHouse
that referenced
this pull request
Apr 1, 2026
The test uses wait_for_query_to_start from shell_config.sh, but this function was only moved there on master (commit 62405eb, Feb 28). Release branches 26.1 and 26.2 do not have this function in their shell_config.sh, causing 100% failure rate ("command not found") when the test was backported via PRs ClickHouse#100853 and ClickHouse#100855. Add a conditional fallback definition of wait_for_query_to_start directly in the test file. The function is only defined if it doesn't already exist (i.e., on older branches). On master and 26.3+ where shell_config.sh already provides the function, the fallback is skipped. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #99483
Cherry-pick pull-request #100854
This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.
The PR source
The PR is created in the CI job