feat: complete show/hide toggle for dynamic items in help menu#112
Closed
ayangweb wants to merge 1 commit into
Closed
feat: complete show/hide toggle for dynamic items in help menu#112ayangweb wants to merge 1 commit into
ayangweb wants to merge 1 commit into
Conversation
charlessnow
approved these changes
Jun 2, 2026
mixc6763-prog
pushed a commit
that referenced
this pull request
Jun 2, 2026
The rollback ItemRow in TrayMenuSettingView was unconditionally added to the Help group, but the corresponding NSMenuItem in installLabHelpMenuItems is only created when AutoUpgradeManager.isLabBuild is true. Stable users saw a non-functional 'Roll Back to Stable…' toggle in menu display settings. Wrap the ItemRow in the same isLabBuild condition used by AppDelegate so the settings toggle only appears when the menu item actually exists.
Contributor
|
感谢贡献 🙏 这个改动已经合并到 main（commit 5814719），并随 Lab 1.1.3.1 一起发布：https://github.com/Clash-FX/ClashFX/releases/tag/1.1.3.1 由于主分支有保护规则、走的是 cherry-pick 合入，所以 GitHub 没能自动把这个 PR 标记为 merged，这里手动关闭。 另外顺手补了一个小修复：「Roll Back to Stable…」的显示开关原本无条件加进设置里，但该菜单项只在 Lab 构建中存在，导致 Stable 用户会看到一个无效开关。现已让开关的显示条件与菜单项创建条件对齐（commit 1715add）。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.