Skip to content

feat: remove lodash-es#887

Merged
tobiasengelhardt merged 1 commit intomasterfrom
pr/remove-lodash
Feb 11, 2021
Merged

feat: remove lodash-es#887
tobiasengelhardt merged 1 commit intomasterfrom
pr/remove-lodash

Conversation

@tobiasengelhardt
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

lodash-es ist dependency. The getNodeById method takes a method for filtering nodes that has to fit the lodash version of find.

Closes #

What is the new behavior?

lodash-es is not a dependency anymore. The getNodeById method takes a method for filtering nodes that has to fit the javascript version of find.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Check if your getNodeById method is using a method not compatible with the javascript version of find.

Other information

BREAKING CHANGES:

getNodeById now uses native javaScript find method instead of lodash find method

BEFORE:

getNodeById(predicate) - predicate needs to support lodash find method

AFTER:

getNodeById(predicate) - predicate needs to support javaScript find method
@tobiasengelhardt tobiasengelhardt merged commit f639c98 into master Feb 11, 2021
@tobiasengelhardt tobiasengelhardt deleted the pr/remove-lodash branch February 11, 2021 10:26
tobiasengelhardt pushed a commit that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant