Hide library resources#188
Merged
Merged
Conversation
kmayoral
pushed a commit
to kmayoral/chucker
that referenced
this pull request
Jan 21, 2020
* Attempt to generate private resources * Update public.xml
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
Before:
After:
📄 Context
After fixing visibility for internal classes I decided to also try to make all the resources we have (like strings, drawables, values, etc.) private, so users won't see them in autocomplete suggestions.
According to https://developer.android.com/studio/projects/android-library#PrivateResources
all we need to do is to create some public resource (might be even empty), so others are marked as private in final
aar.Unfortunately, this approach won't work when the library added as module, like we have in sample app, so wasn't able to check locally.
📝 Changes
Added a single resource marked as public.
Nothing wrong expected.
📝 How to test
Try to get snapshot from Jitpack as
com.github.ChuckerTeam:Chucker:fix~hide_resources-SNAPSHOTand try to check autocomplete in the app using this dependency.