Skip to content

Escape quotes in curl share#1211

Merged
cortinico merged 2 commits into
ChuckerTeam:mainfrom
madlymad:main
Apr 10, 2024
Merged

Escape quotes in curl share#1211
cortinico merged 2 commits into
ChuckerTeam:mainfrom
madlymad:main

Conversation

@madlymad

@madlymad madlymad commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

📷 Screenshots

Share the curl and paste it into postman
Before my change you get that one, which result in an invalid json header.
Screenshot 2024-04-10 at 16 35 20

After my change you get that one, where the json is valid
Screenshot 2024-04-10 at 16 35 04

📄 Context

In our project/server we have a header that contain a JSON formatted text and every time someone try to use the curl from chucker the output curl is not working and result to errors. Having a JSON formatted value in header may seem strange but its not against any RFC.

📝 Changes

📎 Related PR

No relations

🚫 Breaking

No breaking changes

🛠️ How to test

Ideally with a curl that will have a header with quotes "

⏱️ Next steps

No

@madlymad madlymad requested a review from a team as a code owner April 10, 2024 13:43

@christiancastaldi christiancastaldi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@cortinico cortinico merged commit 91526c7 into ChuckerTeam:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants