Skip to content

fix: make pageId required#2084

Merged
samiyac merged 1 commit into
mainfrom
reqd-page-id
May 19, 2026
Merged

fix: make pageId required#2084
samiyac merged 1 commit into
mainfrom
reqd-page-id

Conversation

@samiyac

@samiyac samiyac commented May 19, 2026

Copy link
Copy Markdown
Contributor

Refs: #2052

Without having pageId as required, when the flag experimentalPageIdRouting is enabled, the pageId field is not always populated. This was found while running eval scenarios.

We only add pageIdSchema when tool is page scoped and experimentalPageIdRouting is enabled, so it should be safe to make this change.

@samiyac samiyac requested a review from OrKoN May 19, 2026 11:07
@samiyac samiyac enabled auto-merge May 19, 2026 11:13

@OrKoN OrKoN left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you please update PR description with details on why it was needed and how it works.

@samiyac samiyac added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit d751693 May 19, 2026
17 checks passed
@samiyac samiyac deleted the reqd-page-id branch May 19, 2026 11:33
pull Bot pushed a commit to oogalieboogalie/chrome-devtools-mcp that referenced this pull request May 26, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](ChromeDevTools/chrome-devtools-mcp@chrome-devtools-mcp-v1.0.1...chrome-devtools-mcp-v1.1.0)
(2026-05-26)


### 🎉 Features

* add extraHttpHeaders emulation to emulate tool
([ChromeDevTools#1176](ChromeDevTools#1176))
([6992106](ChromeDevTools@6992106))
* created cursor plugin.json setting file with release auto versioning
([ChromeDevTools#2091](ChromeDevTools#2091))
([10c8205](ChromeDevTools@10c8205))


### 🛠️ Fixes

* Apply CPU throttling to secondary CDP session
([ChromeDevTools#2092](ChromeDevTools#2092))
([3ade962](ChromeDevTools@3ade962))
* **cli:** address pid file creation issues
([ChromeDevTools#2124](ChromeDevTools#2124))
([1b51a52](ChromeDevTools@1b51a52))
* exit on stdin EOF and SIGTERM/SIGINT/SIGHUP, closing the browser
cleanly
([ChromeDevTools#2117](ChromeDevTools#2117))
([43b934c](ChromeDevTools@43b934c))
* Fix throttling info in performance trace output
([ChromeDevTools#2096](ChromeDevTools#2096))
([57f32b0](ChromeDevTools@57f32b0))
* make pageId required
([ChromeDevTools#2084](ChromeDevTools#2084))
([d751693](ChromeDevTools@d751693)),
closes
[ChromeDevTools#2052](ChromeDevTools#2052)
* remove duplicate .mcp.json
([ChromeDevTools#2095](ChromeDevTools#2095))
([dbf6ba9](ChromeDevTools@dbf6ba9))
* Set viewport after updating timeouts when setting emulation
([ChromeDevTools#2134](ChromeDevTools#2134))
([0c3ac37](ChromeDevTools@0c3ac37))
* use pinned version for plugins
([ChromeDevTools#2135](ChromeDevTools#2135))
([8ea5f09](ChromeDevTools@8ea5f09))
* use realpath for MCP roots validation
([ChromeDevTools#2127](ChromeDevTools#2127))
([176eb69](ChromeDevTools@176eb69))


### 📄 Documentation

* align coding agent examples with Antigravity
([ChromeDevTools#2094](ChromeDevTools#2094))
([ce31594](ChromeDevTools@ce31594))
* fix installation instructions for VS Code
([ChromeDevTools#2087](ChromeDevTools#2087))
([9f47df3](ChromeDevTools@9f47df3))


### 🏗️ Refactor

* remove redundant validatePath calls
([ChromeDevTools#2136](ChromeDevTools#2136))
([521c388](ChromeDevTools@521c388))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
samiyac pushed a commit to bcfmtolgahan/chrome-devtools-mcp that referenced this pull request Jun 5, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](ChromeDevTools/chrome-devtools-mcp@chrome-devtools-mcp-v1.0.1...chrome-devtools-mcp-v1.1.0)
(2026-05-26)


### 🎉 Features

* add extraHttpHeaders emulation to emulate tool
([ChromeDevTools#1176](ChromeDevTools#1176))
([6992106](ChromeDevTools@6992106))
* created cursor plugin.json setting file with release auto versioning
([ChromeDevTools#2091](ChromeDevTools#2091))
([10c8205](ChromeDevTools@10c8205))


### 🛠️ Fixes

* Apply CPU throttling to secondary CDP session
([ChromeDevTools#2092](ChromeDevTools#2092))
([3ade962](ChromeDevTools@3ade962))
* **cli:** address pid file creation issues
([ChromeDevTools#2124](ChromeDevTools#2124))
([1b51a52](ChromeDevTools@1b51a52))
* exit on stdin EOF and SIGTERM/SIGINT/SIGHUP, closing the browser
cleanly
([ChromeDevTools#2117](ChromeDevTools#2117))
([43b934c](ChromeDevTools@43b934c))
* Fix throttling info in performance trace output
([ChromeDevTools#2096](ChromeDevTools#2096))
([57f32b0](ChromeDevTools@57f32b0))
* make pageId required
([ChromeDevTools#2084](ChromeDevTools#2084))
([d751693](ChromeDevTools@d751693)),
closes
[ChromeDevTools#2052](ChromeDevTools#2052)
* remove duplicate .mcp.json
([ChromeDevTools#2095](ChromeDevTools#2095))
([dbf6ba9](ChromeDevTools@dbf6ba9))
* Set viewport after updating timeouts when setting emulation
([ChromeDevTools#2134](ChromeDevTools#2134))
([0c3ac37](ChromeDevTools@0c3ac37))
* use pinned version for plugins
([ChromeDevTools#2135](ChromeDevTools#2135))
([8ea5f09](ChromeDevTools@8ea5f09))
* use realpath for MCP roots validation
([ChromeDevTools#2127](ChromeDevTools#2127))
([176eb69](ChromeDevTools@176eb69))


### 📄 Documentation

* align coding agent examples with Antigravity
([ChromeDevTools#2094](ChromeDevTools#2094))
([ce31594](ChromeDevTools@ce31594))
* fix installation instructions for VS Code
([ChromeDevTools#2087](ChromeDevTools#2087))
([9f47df3](ChromeDevTools@9f47df3))


### 🏗️ Refactor

* remove redundant validatePath calls
([ChromeDevTools#2136](ChromeDevTools#2136))
([521c388](ChromeDevTools@521c388))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants