Skip to content

feat: support MCP client roots feature#1945

Merged
OrKoN merged 2 commits into
mainfrom
orkon/igotnoroots
Apr 27, 2026
Merged

feat: support MCP client roots feature#1945
OrKoN merged 2 commits into
mainfrom
orkon/igotnoroots

Conversation

@OrKoN

@OrKoN OrKoN commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

This PR implements https://modelcontextprotocol.io/specification/2025-11-25/client/roots If client specifies roots, all reads and writes to the file system originating in tool calls will denied (including tmp files). The client specified empty list of roots, all filesystem access will be restricted.

Closes #1860

@OrKoN OrKoN force-pushed the orkon/igotnoroots branch 3 times, most recently from eba7359 to 51e3291 Compare April 23, 2026 11:30
@OrKoN OrKoN changed the title feat: support client roots feature feat: support MCP client roots feature Apr 23, 2026
@OrKoN OrKoN requested a review from wolfib April 23, 2026 11:38
Comment thread src/McpContext.ts Outdated
@OrKoN OrKoN force-pushed the orkon/igotnoroots branch 2 times, most recently from a11f796 to abf7160 Compare April 23, 2026 13:55
@OrKoN

OrKoN commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator Author

I realized I might have had a bug in index.ts. PT(another)L.

@OrKoN OrKoN requested a review from wolfib April 23, 2026 13:56
@OrKoN OrKoN force-pushed the orkon/igotnoroots branch 3 times, most recently from 4823288 to 314d91d Compare April 23, 2026 15:10
@OrKoN

OrKoN commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry, I realised again that we should treat empty roots differently from undefined roots (rejecting any file access with empty roots). PTAL

@OrKoN OrKoN requested a review from wolfib April 23, 2026 15:10
@OrKoN OrKoN force-pushed the orkon/igotnoroots branch from 314d91d to d910a7a Compare April 23, 2026 15:18
Comment thread src/McpContext.ts Outdated
Comment thread src/tools/ToolDefinition.ts Outdated
OrKoN and others added 2 commits April 27, 2026 13:49
…0.1616061 (#1952)

Closes #1908

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piotr Paulski <piotrpaulski@chromium.org>
@OrKoN OrKoN force-pushed the orkon/igotnoroots branch from c602eb9 to 96501f4 Compare April 27, 2026 11:49
@OrKoN OrKoN enabled auto-merge April 27, 2026 11:49
@OrKoN OrKoN added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit def53dd Apr 27, 2026
20 checks passed
@OrKoN OrKoN deleted the orkon/igotnoroots branch April 27, 2026 12:03
pull Bot pushed a commit to Mu-L/chrome-devtools-mcp that referenced this pull request May 4, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.24.0](ChromeDevTools/chrome-devtools-mcp@chrome-devtools-mcp-v0.23.0...chrome-devtools-mcp-v0.24.0)
(2026-05-02)


### 🎉 Features

* agentic browsing in lighthouse
([ChromeDevTools#1931](ChromeDevTools#1931))
([5fa2750](ChromeDevTools@5fa2750))
* **cli:** generate commands for conditional tools
([ChromeDevTools#1962](ChromeDevTools#1962))
([b2b3e99](ChromeDevTools@b2b3e99))
* group identical consecutive console messages in list_console_messages
([ChromeDevTools#1939](ChromeDevTools#1939))
([dbddb2e](ChromeDevTools@dbddb2e))
* support MCP client roots feature
([ChromeDevTools#1945](ChromeDevTools#1945))
([def53dd](ChromeDevTools@def53dd))


### 🛠️ Fixes

* add proactive tool rejection when dialog is open
([ChromeDevTools#1978](ChromeDevTools#1978))
([6ce254e](ChromeDevTools@6ce254e))
* always allow tmpdir access with client roots
([ChromeDevTools#1984](ChromeDevTools#1984))
([a90378a](ChromeDevTools@a90378a))
* **cli:** re-generate cli correctly
([ChromeDevTools#1969](ChromeDevTools#1969))
([8cbdb8d](ChromeDevTools@8cbdb8d))
* handle errors due to open dialogs during tool calls
([ChromeDevTools#1953](ChromeDevTools#1953))
([06b331f](ChromeDevTools@06b331f))
* note about missing elements should not show in verbose mode
([ChromeDevTools#1950](ChromeDevTools#1950))
([80bee1e](ChromeDevTools@80bee1e))
* **telemetry:** bucketize string length
([ChromeDevTools#1972](ChromeDevTools#1972))
([bf3cb58](ChromeDevTools@bf3cb58))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the roots feature from the MCP spec

3 participants