feat: make pageId routing always-on#1777
Open
bcfmtolgahan wants to merge 2 commits into
Open
Conversation
cceb6af to
394fbd2
Compare
OrKoN
reviewed
Apr 1, 2026
Collaborator
|
TODO: this cannot land before the fixes to the wait helpers are made to correctly operate on the specified page. |
Collaborator
|
TODO: evaluate that the model uses pageId correctly via eval scenarios in https://github.com/ChromeDevTools/chrome-devtools-mcp/tree/main/scripts/eval_scenarios |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
Splits out from #1244 per review feedback. 'waitForEventsAfterAction' previously lived in 'McpContext' and always used the selected page's CPU/network throttling settings. With pageId routing, a tool can target a different page than the selected one, meaning wrong throttling multipliers were applied. Moving the method to 'McpPage' fixes this: each tool now calls 'page.waitForEventsAfterAction(...)' and gets the correct page's emulation settings. 'getNetworkMultiplierFromString' is extracted to 'WaitForHelper.ts' to avoid a circular import (McpContext → McpPage already exists). Unblocks #1777.
wolfib
pushed a commit
that referenced
this pull request
Apr 1, 2026
Splits out from #1244 per review feedback. 'waitForEventsAfterAction' previously lived in 'McpContext' and always used the selected page's CPU/network throttling settings. With pageId routing, a tool can target a different page than the selected one, meaning wrong throttling multipliers were applied. Moving the method to 'McpPage' fixes this: each tool now calls 'page.waitForEventsAfterAction(...)' and gets the correct page's emulation settings. 'getNetworkMultiplierFromString' is extracted to 'WaitForHelper.ts' to avoid a circular import (McpContext → McpPage already exists). Unblocks #1777.
Collaborator
|
@bcfmtolgahan would you be up to rebasing this PR? |
5f96b59 to
7bb6554
Compare
Contributor
Author
|
@OrKoN rebased onto latest main. Adapted to the new 'ToolHandler.ts', location for schema injection and routing. Squashed to a single commit since the changes got intertwined during the adaptation, happy to split if preferred. |
bac9c3b to
702a9b9
Compare
Collaborator
|
FYI we made pageId required when the page id routing is enabled because it makes the MCP server perform better with the agents. But it also causes a regression for the CLI interface where the required pageId becomes a mandatory positional argument for all commands and the skill is not updated. I think we would to disable pageId routing for the CLI for now. cc @samiyac |
Collaborator
|
also the tests fail because the pageId is now a required argument. |
pull Bot
pushed a commit
to Stars1233/chrome-devtools-mcp
that referenced
this pull request
May 27, 2026
Refs ChromeDevTools#1777 This change makes pageId as the first argument for CLI if experimentalPageIdRouting flag is enabled Co-authored-by: Samiya Caur <samiyac@chromium.org>
samiyac
added a commit
to bcfmtolgahan/chrome-devtools-mcp
that referenced
this pull request
Jun 5, 2026
Refs ChromeDevTools#1777 This change makes pageId as the first argument for CLI if experimentalPageIdRouting flag is enabled Co-authored-by: Samiya Caur <samiyac@chromium.org>
Rename --experimental-page-id-routing to --page-id-routing and enable it
by default. Users can opt out with --no-page-id-routing if token overhead
is unacceptable or routing does not work as expected.
- Rename serverArgs.experimentalPageIdRouting to pageIdRouting and set
default: true; describe text updated to reflect opt-out semantics.
- Update ToolHandler.ts schema injection and page resolution to use the
new flag name.
- Drop the now-redundant delete of pageIdRouting from chrome-devtools-cli
start options (was previously removing experimentalPageIdRouting).
- Update evaluate_script to use cliArgs.pageIdRouting and guard
getPageById with a request.params.pageId check so passing the flag
without a pageId no longer throws (mirrors the guard used in
ToolHandler.ts).
- Improve pageIdSchema description: explain list_pages and selected-page
fallback so the field is self-documenting.
- Fix generate-docs.ts to inject pageIdSchema for page-scoped tools so
tool-reference.md surfaces pageId on every page-scoped tool; pass a
slim flag so slim docs stay unchanged.
- Update eval scenarios to rely on the new default instead of passing
--experimental-page-id-routing; update the example flag in the
TestScenario JSDoc accordingly.
- Fix pageId type in script.test.ts (string -> number).
- Regenerated docs/tool-reference.md, README options section, and
src/telemetry/{flag_usage_metrics,tool_call_metrics}.json.
- Add pageIdRouting/page-id-routing to the cli.test.ts default args
fixture to reflect the new default.
Rename --experimental-page-id-routing to --page-id-routing and enable it
by default. Users can opt out with --no-page-id-routing if token overhead
is unacceptable or routing does not work as expected.
- Rename serverArgs.experimentalPageIdRouting to pageIdRouting and set
default: true; describe text updated to reflect opt-out semantics.
- Update ToolHandler.ts schema injection and page resolution to use the
new flag name.
- Drop the now-redundant delete of pageIdRouting from chrome-devtools-cli
start options (was previously removing experimentalPageIdRouting).
- Update evaluate_script to use cliArgs.pageIdRouting and guard
getPageById with a request.params.pageId check so passing the flag
without a pageId no longer throws (mirrors the guard used in
ToolHandler.ts).
- Improve pageIdSchema description: explain list_pages and selected-page
fallback so the field is self-documenting.
- Fix generate-docs.ts to inject pageIdSchema for page-scoped tools so
tool-reference.md surfaces pageId on every page-scoped tool; pass a
slim flag so slim docs stay unchanged.
- Update eval scenarios to rely on the new default instead of passing
--experimental-page-id-routing; update the example flag in the
TestScenario JSDoc accordingly.
- Fix pageId type in script.test.ts (string -> number).
- Regenerated docs/tool-reference.md, README options section, and
src/telemetry/{flag_usage_metrics,tool_call_metrics}.json.
- Add pageIdRouting/page-id-routing to the cli.test.ts default args
fixture to reflect the new default.
163061c to
378b5fa
Compare
Contributor
Author
|
@OrKoN Rebased onto latest main and prototyped the CLI fix you mentioned: gated pageId injection on !viaCli (daemon + generate-cli.ts already pass --viaCli), so CLI commands drop the mandatory pageId positional while the MCP server keeps it. Also fixed the failing e2e tests. Suite is green. Happy to push this if it matches what you had in mind or if you'd rather own the CLI-disable (or prefer making pageId optional instead), just let me know and I'll hold off. |
Contributor
|
Hi @bcfmtolgahan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits out from #1244 per review feedback.
Removes the
experimentalPageIdRoutingflag —pageIdis now alwaysexposed on page-scoped tools. The flag is kept as a no-op for backwards
compatibility.