Skip to content

Metadata deleter Implementation#14

Merged
carolyntang merged 6 commits intokudu-masterfrom
metadataDeleter
Mar 18, 2019
Merged

Metadata deleter Implementation#14
carolyntang merged 6 commits intokudu-masterfrom
metadataDeleter

Conversation

@carolyntang
Copy link
Copy Markdown
Collaborator

@carolyntang carolyntang commented Mar 18, 2019

Signed-off-by: carolyntang carolyntang1129@gmail.com

Signed-off-by: carolyntang <carolyntang1129@gmail.com>
Signed-off-by: carolyntang <carolyntang1129@gmail.com>
Signed-off-by: carolyntang <carolyntang1129@gmail.com>
Copy link
Copy Markdown
Collaborator

@dannyqiu dannyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run the formatter on this code as well

Signed-off-by: carolyntang <carolyntang1129@gmail.com>
@carolyntang carolyntang requested a review from dannyqiu March 18, 2019 16:42
Copy link
Copy Markdown
Collaborator

@dannyqiu dannyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carolyntang carolyntang merged commit c860fb8 into kudu-master Mar 18, 2019
@dannyqiu dannyqiu deleted the metadataDeleter branch March 24, 2019 03:35
ChesleyTan pushed a commit that referenced this pull request Apr 22, 2019
* Implement MetadataDeleter

Signed-off-by: carolyntang <carolyntang1129@gmail.com>

* Implement MetadataDeleter

Signed-off-by: carolyntang <carolyntang1129@gmail.com>

* Implement MetadataDeleter

Signed-off-by: carolyntang <carolyntang1129@gmail.com>

* format

Signed-off-by: carolyntang <carolyntang1129@gmail.com>

* Modify on primary id condition

Signed-off-by: carolyntang <carolyntang1129@gmail.com>
ChesleyTan pushed a commit that referenced this pull request Apr 22, 2019
* Implement MetadataDeleter

Signed-off-by: carolyntang <carolyntang1129@gmail.com>

* Implement MetadataDeleter

Signed-off-by: carolyntang <carolyntang1129@gmail.com>

* Implement MetadataDeleter

Signed-off-by: carolyntang <carolyntang1129@gmail.com>

* format

Signed-off-by: carolyntang <carolyntang1129@gmail.com>

* Modify on primary id condition

Signed-off-by: carolyntang <carolyntang1129@gmail.com>
ChesleyTan pushed a commit that referenced this pull request Apr 22, 2019
* Implement MetadataDeleter

* format

* Modify on primary id condition

Signed-off-by: carolyntang <carolyntang1129@gmail.com>
dannyqiu pushed a commit that referenced this pull request May 3, 2019
* Implement MetadataDeleter

* format

* Modify on primary id condition

Signed-off-by: carolyntang <carolyntang1129@gmail.com>
dannyqiu pushed a commit that referenced this pull request May 3, 2019
* Implement MetadataDeleter

* format

* Modify on primary id condition

Signed-off-by: carolyntang <carolyntang1129@gmail.com>
dannyqiu pushed a commit that referenced this pull request May 6, 2019
* Implement MetadataDeleter

* format

* Modify on primary id condition

Signed-off-by: carolyntang <carolyntang1129@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants