Fixes for Swift 5.7 compiler by lukeredpath · Pull Request #4823 · ChartsOrg/Charts

lukeredpath · 2022-05-13T23:24:03Z

Issue Link 🔗

I'm currently experimenting with the latest development Swift 5.7 toolchain and the Charts library was not compiling due to a bug in the implementation of RangeReplaceableCollection on ChartDataItem.

This PR fixes that by adding the missing protocol method and also fixes a couple of compiler warnings (which I think also exist on the latest stable toolchain).

More info on this here: swiftlang/swift#58737 - the reason this compiled pre-5.7 was due to a bug in Swift which was due to be fixed in 5.6, reverted and will ship in 5.7 by the looks of it.

Goals ⚽

Library can now be compiled with Swift 5.7.

Testing Details 🔍

Library continues to compile under 5.6.

I wasn't able to get the snapshots to pass on my M1 Max laptop - maybe I'm using the wrong simulator. The failures were very subtle and I don't think are related to this change.

lukeredpath · 2022-05-13T23:25:57Z

.gitignore

 *.ipa
 *.dSYM.zip
 *.dSYM
+*.dia


These files get spewed out when compiling with the development toolchain so I added them to the ignore file.

lukeredpath · 2022-05-13T23:26:17Z

Package.resolved

-          "revision": "6b24333510e9044cf4716a07bed65eeed6bc6393",
-          "version": "0.0.8"
+          "revision": "0a5bc04095a675662cf24757cc0640aa2204253b",
+          "version": "1.0.2"


Xcode updated these automatically and I think its a reasonable update as they were very outdated.

lukeredpath · 2022-05-13T23:26:28Z

Source/Charts/Data/Implementations/Standard/ChartDataSet.swift

+        entries.replaceSubrange(subrange, with: newElements)
+        notifyDataSetChanged()
+    }
+


This was the fix.

what's the original issue here? It has been too long; sorry

I would like to get this merged asap, so bear with me my direct asking

also - if we are compiling with old Swift, like 5.0 or 5.4, will this cause a regression? Not fulling understanding the issue

My understanding of the original bug is that you've always needed replaceSubrange to conform to RangeReplaceableCollection but the compiler wasn't failing when it was missing until 5.7 fixed this issue. You'd need to compile with an older toolchain to be sure, I don't know how far back you want to support in terms of toolchain.

basically we usually just support latest one; but given this issue is totally different between 5.6/5.7, I'm not wure what would happen in the field.

Would @avaialble(iOS 16) , (macOS, 13) or something similar solve it?

I was trying to compile on Xcode beta3, howerver, it still throws

Type 'ChartDataSet' does not conform to protocol 'RangeReplaceableCollection' Unavailable instance method 'replaceSubrange(_:with:)' was used to satisfy a requirement of protocol 'RangeReplaceableCollection'

which Xcode beta you are building?

lukeredpath · 2022-05-13T23:26:36Z

Source/Charts/Utils/ChartUtils.swift

    }

-    open func drawText(_ text: String, at point: CGPoint, anchor: CGPoint = CGPoint(x: 0.5, y: 0.5), angleRadians: CGFloat, attributes: [NSAttributedString.Key : Any]?)
+    public func drawText(_ text: String, at point: CGPoint, anchor: CGPoint = CGPoint(x: 0.5, y: 0.5), angleRadians: CGFloat, attributes: [NSAttributedString.Key : Any]?)


Went with the Xcode suggested fix here.

what's the error message for open?

I can't remember now, sorry.

what's the error message for open?

quoted from this issue:

Build error around CandleStickChartRenderer's and RadarChartRenderer's drawData(context: CGContext) where the IndexingIterator are not equivalent. Raw message:

error build: Referencing instance method 'makeIterator()' on 'Collection' requires the types 'IndexingIterator' and 'IndexingIterator' be equivalent

The quoted issue doesn't seem to be relevant here. For me, the issue

CandleStickChartRenderer.swift:41:59: error build: Referencing instance method 'makeIterator()' on 'Collection' requires the types 'IndexingIterator<ChartData>' and 'IndexingIterator<CandleChartData>' be equivalent

still was still there with this PR's branch. It was gone only after I made the required conversions: radarData as ChartData in RadarChartRenderer:55 and candleData as ChartData at CandleStickChartRenderer:41

I am using Xcode 14 beta 3

The open vs public is not an error, but a build warning:

Non-'@objc' instance method in extensions cannot be overridden; use 'public' instead

The quoted issue doesn't seem to be relevant here. For me, the issue

CandleStickChartRenderer.swift:41:59: error build: Referencing instance method 'makeIterator()' on 'Collection' requires the types 'IndexingIterator<ChartData>' and 'IndexingIterator<CandleChartData>' be equivalent

still was still there with this PR's branch. It was gone only after I made the required conversions: radarData as ChartData in RadarChartRenderer:55 and candleData as ChartData at CandleStickChartRenderer:41

I am using Xcode 14 beta 3

This is the way!

dangthaison91 · 2022-07-26T11:28:18Z

I also face other compiler errors:

EaseOutBack in ChartAnimationEasing.swift
This fix worked for me Add double mark for compiler check related with issue #4835 #4836

    internal static let EaseOutBack = { (elapsed: TimeInterval, duration: TimeInterval) -> Double in
        let s: TimeInterval = 1.70158
        var position: TimeInterval = elapsed / duration
        position -= 1.0
        return Double( position * position * ((s + Double(1.0)) * position + s) + Double(1.0) )
    }

func drawDataSet in RadarChartRenderer.swift

        for case let set as RadarChartDataSetProtocol in (radarData as ChartData) where set.isVisible
        {
            drawDataSet(context: context, dataSet: set, mostEntries: mostEntries)
        }

CandleStickChartRenderer.swift

        for case let set as CandleChartDataSetProtocol in (candleData as ChartData) where set.isVisible
        {
              drawDataSet(context: context, dataSet: set)
        }

from: #4860 (comment)

ChartsOrg#4823 (comment)

o15a3d4l11s2 · 2022-08-12T08:50:08Z

Any update when this could be reviewed and merged?

ChartsOrg#4823 (comment)

liuxuan30 · 2022-08-25T08:17:35Z

Any update when this could be reviewed and merged?

my comments above haven't resolved yet, not sure yet. I tried this PR with beta 3, however couldn't build & run.

Probably the latest time is when Xcode GM released and I can try it without bothering from beta releases.

ChartsOrg#4823 (comment) (cherry picked from commit 696c6e5)

pmairoldi · 2022-08-28T00:35:04Z

Thanks for contributing!

leohidalgo · 2022-08-29T18:54:49Z

@pmairoldi do you have a deadline for a new version?

pmairoldi · 2022-08-29T18:55:47Z

Waiting for Xcode 14 gm before releasing anything.

leohidalgo · 2022-09-07T20:37:24Z

@pmairoldi The GM is here, let me know if I can help you with anything.

liuxuan30 · 2022-09-09T01:49:10Z

Waiting for Xcode 14 gm before releasing anything.

thanks pal! been busy with the new job, as we also had tons of issues regarding Xcode 14 RC and iOS 16

lukeredpath commented May 13, 2022

View reviewed changes

lukeredpath marked this pull request as ready for review May 13, 2022 23:26

pmairoldi added the enhancement label May 25, 2022

Brett-Best mentioned this pull request Jul 7, 2022

Support for Xcode 14 #4860

Closed

dangthaison91 pushed a commit to dangthaison91/Charts that referenced this pull request Jul 26, 2022

Fix Xcode 14 compile error

f7e3a8a

ChartsOrg#4823 (comment)

dangthaison91 mentioned this pull request Jul 26, 2022

Fix Xcode 14 and Swift 5.7 compiler error #4874

Closed

waterskier2007 mentioned this pull request Jul 27, 2022

Fix Xcode 14 compile error waterskier2007/Charts#1

Merged

JackMoseley2001 mentioned this pull request Jul 30, 2022

Fix Xcode 14 compile error JackMoseley2001/ChartsKit#2

Merged

dangthaison91 pushed a commit to dangthaison91/Charts that referenced this pull request Aug 2, 2022

Fix Xcode 14 compile error

50db7f8

ChartsOrg#4823 (comment)

dangthaison91 pushed a commit to dangthaison91/Charts that referenced this pull request Aug 2, 2022

Fix Xcode 14 compile error

696c6e5

ChartsOrg#4823 (comment)

JackMoseley2001 pushed a commit to JackMoseley2001/ChartsKit that referenced this pull request Aug 2, 2022

Fix Xcode 14 compile error

5ed992e

ChartsOrg#4823 (comment)

saltyskip mentioned this pull request Aug 9, 2022

Fix Xcode 14 compile error saltyskip/Charts#1

Merged

jamikado mentioned this pull request Aug 9, 2022

Fix Xcode 14 compile error ovuline/ios-Charts#2

Merged

mustiikhalil pushed a commit to fishbrain/Charts that referenced this pull request Aug 11, 2022

Fix Xcode 14 compile error

3fc11ea

ChartsOrg#4823 (comment)

grahamburgsma pushed a commit to ConstantHealth/Charts that referenced this pull request Aug 16, 2022

Fix Xcode 14 compile error

8157644

ChartsOrg#4823 (comment)

lukeredpath added 2 commits August 18, 2022 14:21

Fixes protocol implementation when compiled with Swift 5.7

3af939e

Fix warnings

be742eb

lukeredpath force-pushed the lukeredpath/swift-5.7 branch from c3701a4 to be742eb Compare August 18, 2022 13:21

waterskier2007 mentioned this pull request Aug 23, 2022

Fix Xcode 14 compile error waterskier2007/Charts#2

Merged

tasostsolis pushed a commit to tasostsolis/Charts that referenced this pull request Aug 26, 2022

Fix Xcode 14 compile error

50090d4

ChartsOrg#4823 (comment) (cherry picked from commit 696c6e5)

pmairoldi self-assigned this Aug 27, 2022

Merge branch 'master' into lukeredpath/swift-5.7

4720a29

pmairoldi merged commit 1ae0003 into ChartsOrg:master Aug 28, 2022

tomcheung-crypto mentioned this pull request Sep 1, 2022

Trading chart xcode 14 monacohq/Charts#8

Open

lukeredpath deleted the lukeredpath/swift-5.7 branch September 7, 2022 23:31

pinkpika pushed a commit to cmmobile/Charts that referenced this pull request Oct 5, 2022

fix: fix for xcode 14.0.1 ChartsOrg#4823

a9250a6

mk-wang pushed a commit to mk-wang/Charts that referenced this pull request Nov 4, 2022

Fixes for Swift 5.7 compiler : ChartsOrg#4823

c5fc7cb

Uh oh!

Conversation

lukeredpath commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Link 🔗

Goals ⚽

Testing Details 🔍

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liuxuan30 Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dangthaison91 commented Jul 26, 2022

Uh oh!

o15a3d4l11s2 commented Aug 12, 2022

Uh oh!

liuxuan30 commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmairoldi commented Aug 28, 2022

Uh oh!

leohidalgo commented Aug 29, 2022

Uh oh!

pmairoldi commented Aug 29, 2022

Uh oh!

leohidalgo commented Sep 7, 2022

Uh oh!

liuxuan30 commented Sep 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

lukeredpath commented May 13, 2022 •

edited

Loading

liuxuan30 Jul 8, 2022 •

edited

Loading

liuxuan30 commented Aug 25, 2022 •

edited

Loading