Add gradient bars for BarChart [master branch] by larryonoff · Pull Request #4411 · ChartsOrg/Charts

larryonoff · 2020-07-08T07:52:59Z

This PR adds functionality to draw gradient bars with BarChartDataSet based on master branch

liuxuan30 · 2020-07-13T01:13:01Z

ChartsDemo-iOS/Swift/Demos/BarChartViewController.swift

        if let set = chartView.data?.dataSets.first as? BarChartDataSet {
-            set1 = set
-            set1.replaceEntries(yVals)
+            setup(set)


let's rename to a more meaningful name to imply it's about setup gradient

liuxuan30 · 2020-07-13T01:15:40Z

ChartsDemo-iOS/Swift/Demos/LineChart1ViewController.swift

                set.mode = (set.mode == .cubicBezier) ? .horizontalBezier : .cubicBezier
            }
            chartView.setNeedsDisplay()
+        case .toggleGradient:


is it possible for you to add the objc portion? (feel free to say no)

liuxuan30 · 2020-07-13T01:18:50Z

Source/Charts/Renderers/BarChartRenderer.swift

+        if dataSet.drawBarGradientEnabled {
+            drawGradientBars(context: context, dataSet: dataSet, buffer: buffer, matrix: valueToPixelMatrix)
+        } else {
+            drawDefaultBars(context: context, dataSet: dataSet, dateSetIndex: index, buffer: buffer)


maybe drawNormalBars or standard bars, etc? not sure which is better. @jjatie idea?

liuxuan30 · 2020-07-13T01:26:59Z

Source/Charts/Renderers/BarChartRenderer.swift

+                context.setLineWidth(dataSet.barBorderWidth)
+                context.stroke(barRect)
+            }
+        }


in gradient bars, accessibilityOrderedElements is missing?

@liuxuan30 pushed commit. Hope that I did it correct.

liuxuan30 · 2020-07-13T01:32:07Z

Source/Charts/Utils/Platform.swift


+extension NSUIColor
+{
+    var nsuirgba: (red: CGFloat, green: CGFloat, blue: CGFloat, alpha: CGFloat)? {


though the imp is different, here are two var nsuirgba in one extension? typo? or two vars indeed?

@larryonoff can you get the notification? I basically finished the review, jsut some minor issues to address.

liuxuan30 · 2020-07-13T01:32:53Z

Source/Charts/Utils/Platform.swift


+extension NSUIColor
+{
+    var nsuirgba: (red: CGFloat, green: CGFloat, blue: CGFloat, alpha: CGFloat)? {


move { to a new line

liuxuan30 · 2020-07-13T01:34:31Z

@jjatie @danielgindi please also take a look. Generally I'm accepting except for some minor issues.

prats-iosdeveloper · 2020-07-22T13:11:08Z

Hi i want to implement gradient bars with round corners when to expect this merge?

larryonoff · 2020-07-22T13:18:37Z

@liuxuan30 @danielgindi Hi. Sorry for the delay in responding. Really busy these weeks. I won't be able to check this PR for some time. But I think It can be done without my help easily.

liuxuan30 · 2020-07-27T01:58:47Z

@larryonoff I could fix most of them, but two left need your input,

1st is about accessibilityOrderedElements in the new code, I didn't see it. Did you just forget or because there are issues?

2st is about the var nsuirgba, I need your input which is new, because you added two same var with different implementation. And I can't tell which is the right one.

rename `setup(_ dataSet: BarChartDataSet)` to `setupBarGradient(_ dataSet: BarChartDataSet)`

rename `drawDefaultBars` to `drawNormalBars`

larryonoff · 2020-07-27T08:28:21Z

@liuxuan30

1st is about accessibilityOrderedElements in the new code, I didn't see it. Did you just forget or because there are issues?

just pushed commit

2st is about the var nsuirgba, I need your input which is new, because you added two same var with different implementation. And I can't tell which is the right one.

nsuirgba implementation differs for macOS and iOS.

iOS uses UIColor.getRed, which returns success / not and only available for iOS .
macOS uses NSColor.getRed, which doesn't return any values (I'm not sure, but it may crash if input parameters doesn't fit RGB model).

liuxuan30 · 2020-07-28T00:17:14Z

@larryonoff I saw nsuirgba is ported from 4.0 branch.

I was evaluating which branch is better to merge, merging into master will have more conflicts while merging 4.0 branch, so I was kind of unsure.

anyway, I could take on from here. Thanks!

liuxuan30 · 2020-07-28T01:32:17Z

I think the best way is to merge 4.0 branch first, and try to merge this.

I'm actively working on the 4.0 merge right now, and it could take 1-2 weeks to resolve the conflicts.

@danielgindi @jjatie

ChartsOrg#4411

StackHelp · 2020-11-04T12:48:36Z

@liuxuan30 Can we have a merged file in next few weeks?

liuxuan30 · 2020-11-06T07:31:45Z

I think so, @larryonoff so we have merged the 4.0 branch into master, now this is the next we want to merge. I'm switching to master base

liuxuan30 · 2020-11-06T07:36:43Z

@larryonoff any chance you could fix the conflicts?

larryonoff · 2020-11-06T07:54:40Z

@liuxuan30 hey! sorry, but not in a week. very busy.

StackHelp · 2020-11-24T09:40:13Z

@larryonoff @liuxuan30 Any chance to update in this week?

liuxuan30 · 2020-12-14T03:20:18Z

Sorry I‘m super busy recently as well. I hope someone could help on this PR, basically solve the conflict with master.

4np · 2020-12-15T13:23:47Z

This would be easy to accomplish by providing your custom renderer, if #4297 was merged.

glennposadas · 2021-02-16T09:26:32Z

Hi everyone! Sorry for hijacking this PR. But I';ve been reading the commits, and I still have no idea how to apply gradient colors to my HorizontalBarChartView. I don't see any property too in BarChartDataSet that is related to gradient. I'm using 4.0.0. Any idea? Thanks!

EDIT: I suppose this hasn't been merged to the Master.

dbrisinda · 2023-05-26T23:59:55Z

May 2023 and still waiting on this...

larryonoff added 2 commits July 8, 2020 11:04

Add gradient bars for BarChart

e6f82b3

Add gradient start and gradient end to bar chart renderer

842b0d8

larryonoff force-pushed the bar-chart-gradient-3.x branch from 78706eb to 842b0d8 Compare July 8, 2020 08:04

larryonoff mentioned this pull request Jul 8, 2020

Add gradient bars for BarChart #3533

Closed

liuxuan30 added 2 commits July 13, 2020 09:26

update code style

b7af4db

update code style

30c8b21

liuxuan30 requested changes Jul 13, 2020

View reviewed changes

liuxuan30 self-assigned this Jul 13, 2020

liuxuan30 mentioned this pull request Jul 13, 2020

Add Gradient to Bar Chart - BarChartDataSet #4385

Closed

liuxuan30 added 2 commits July 27, 2020 10:07

Update BarChartViewController.swift

be3ddb3

rename `setup(_ dataSet: BarChartDataSet)` to `setupBarGradient(_ dataSet: BarChartDataSet)`

Update BarChartRenderer.swift

204f66e

rename `drawDefaultBars` to `drawNormalBars`

liuxuan30 changed the base branch from master to GradientBars July 27, 2020 02:15

Add accessibilityOrderedElements support

e59ade1

fatbobman added a commit to fatbobman/Charts that referenced this pull request Oct 15, 2020

增加了给barChart增加渐变

5ed7003

ChartsOrg#4411

liuxuan30 changed the base branch from GradientBars to master November 6, 2020 07:36

liuxuan30 assigned jjatie Nov 6, 2020

4np mentioned this pull request Jan 29, 2021

Review / merge PR #4297 #4569

Open

ShresthPratapSingh mentioned this pull request Jun 3, 2021

Feature Request:- Add Gradient to Bar chart Bars #4652

Open

Uh oh!

Conversation

larryonoff commented Jul 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liuxuan30 commented Jul 13, 2020

Uh oh!

prats-iosdeveloper commented Jul 22, 2020

Uh oh!

larryonoff commented Jul 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxuan30 commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

larryonoff commented Jul 27, 2020

Uh oh!

liuxuan30 commented Jul 28, 2020

Uh oh!

liuxuan30 commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StackHelp commented Nov 4, 2020

Uh oh!

liuxuan30 commented Nov 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxuan30 commented Nov 6, 2020

Uh oh!

larryonoff commented Nov 6, 2020

Uh oh!

StackHelp commented Nov 24, 2020

Uh oh!

liuxuan30 commented Dec 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

4np commented Dec 15, 2020

Uh oh!

glennposadas commented Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbrisinda commented May 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

larryonoff commented Jul 22, 2020 •

edited

Loading

liuxuan30 commented Jul 27, 2020 •

edited

Loading

liuxuan30 commented Jul 28, 2020 •

edited

Loading

liuxuan30 commented Nov 6, 2020 •

edited

Loading

liuxuan30 commented Dec 14, 2020 •

edited

Loading

glennposadas commented Feb 16, 2021 •

edited

Loading