Restored old performance in ChartDataSet#3216
Restored old performance in ChartDataSet#3216liuxuan30 merged 1 commit intoChartsOrg:masterfrom jjatie:restoring-old-performance
Conversation
Temporary fix for calcMinMax frequency. Better implementation coming for Charts 4
Codecov Report
@@ Coverage Diff @@
## master #3216 +/- ##
==========================================
- Coverage 22.89% 22.87% -0.02%
==========================================
Files 116 116
Lines 15609 15618 +9
Branches 272 272
==========================================
Hits 3573 3573
- Misses 12000 12009 +9
Partials 36 36
Continue to review full report at Codecov.
|
|
hmm.. what PR is before this invert? I don't remember you particularly have a performance enhance PR？ |
|
I don't know which one was the problem. I think it was when I moved to the |
|
Weird I didn't catch this performance drop. |
|
wait a minute. I checked it's #3000 @objc open var values: [ChartDataEntry]
{
get
{
return _values
}
set
{
_values = newValue
notifyDataSetChanged()
}
}I didn't see |
|
eh, I kind of start to recall. However for |
|
@jjatie do you think it's the right behavior for |
|
Yes, that’s the reason why. didSet is called whenever the underlying data mutates (excluding direct memory access). A computed variable doesn’t have underlying data, so it doesn’t make sense for it to be called on append/remove. There’s a couple of major architectural changes I’m going to make over the next couple weeks. After that I’ll work in making performance better for 4.0 |
|
@jjatie take some rest. |
* 'master' of https://github.com/danielgindi/Charts: Restored old performance (ChartsOrg#3216) Support other bundle than main MarkerView.viewFromXib() (ChartsOrg#3215) For ChartsOrg#2840. add dataIndex parameter in `highlightValue()` calls (ChartsOrg#2852) Balloon Marker indicates position of data (ChartsOrg#3181) bump Info.plist version BubbleChart uses correct colour for index now. # Conflicts: # Source/Charts/Mark/BalloonMarker.swift
Temporary fix for calcMinMax frequency. Better implementation coming for Charts 4
Charts 3.0.5 (the current version) introduced a bug with caused a performance drop in real time charts (ChartsOrg/Charts#3166). The patch will be released with the 3.1 version in the following weeks (ChartsOrg/Charts#3216) As for now, updatesIntervalOn is set from 100Hz to 10Hz until the 3.1 is released.
Temporary fix for calcMinMax frequency. Better implementation coming for Charts 4
* master: (55 commits) Refactors -[tableView:cellForRowAtIndexPath:] (ChartsOrg#3326) fix ChartsOrg#3311. Need one more key for iOS 11 camera roll saving revert a mistake, fix ChartsOrg#3299 add pie chart unit tests (ChartsOrg#3297) ChartsOrg#3287: align Objc and Swift demos balloon marker update changelog Min and Max reset when clearing ChartDataSet (Fixes ChartsOrg#3260) Restored old performance (ChartsOrg#3216) Support other bundle than main MarkerView.viewFromXib() (ChartsOrg#3215) For ChartsOrg#2840. add dataIndex parameter in `highlightValue()` calls (ChartsOrg#2852) Balloon Marker indicates position of data (ChartsOrg#3181) bump Info.plist version Fixed a duplicated assignment compared with obj-c code. (ChartsOrg#3179) Updated README for 3.0.5 (ChartsOrg#3183) BubbleChart uses correct colour for index now. Added custom text alignment for noData Fixes the distance issue between the legend and the horizontal bar chart (Fixes ChartsOrg#2138) (ChartsOrg#2214) call setNeedsDisplay() here to trigger render noDataText (ChartsOrg#3198) 添加定制TY的Mark 添加修改过的Mark到工程中 ... # Conflicts: # ICXCharts.podspec
for #3166
Temporary fix for calcMinMax frequency.
Better implementation coming for Charts 4