fix programatical unhighlighting for BarCharView#3159
Merged
jjatie merged 1 commit intoChartsOrg:masterfrom Jan 12, 2018
Merged
fix programatical unhighlighting for BarCharView#3159jjatie merged 1 commit intoChartsOrg:masterfrom
jjatie merged 1 commit intoChartsOrg:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3159 +/- ##
==========================================
- Coverage 22.97% 22.97% -0.01%
==========================================
Files 116 116
Lines 15534 15535 +1
Branches 271 271
==========================================
Hits 3569 3569
- Misses 11929 11930 +1
Partials 36 36
Continue to review full report at Codecov.
|
Collaborator
|
Thanks! |
liuxuan30
reviewed
Jan 12, 2018
| { | ||
| highlightValue(h, callDelegate: true) | ||
| lastHighlighted = h | ||
| highlightValue(h, callDelegate: true) |
Member
There was a problem hiding this comment.
why we change the order here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue with reseting the highlight manually from code. The lastHighlighted property of ChartViewBase was not set to nil. Thus, calling chartView.highlightValue(nil) in the delegate method chartValueSelected( chartView: entry: highlight:)_ did not do anything, and the next time user tapped a bar the chartValueNothingSelected method was called instead of the intended chartValueSelected.