Codecov Report

Merging #3178 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
+ Coverage   22.99%   22.99%   +<.01%     
==========================================
  Files         116      116              
  Lines       15541    15540       -1     
  Branches      272      272              
==========================================
  Hits         3573     3573              
+ Misses      11932    11931       -1     
  Partials       36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0011c35...12f3978. Read the comment docs.

I only see highlightValues(_ highs: [Highlight]?) nil out lastHighlighted, but highlightValue does not.
There used to be a PR in func clear() specifically set lastHighlighted to nil because some small bugs, not cleaning lastHighlighted state and causes wrong highlight.
I think we need a deeper look to make sure this PR is safe.

@jjatie where you say lastHighlighted = nil is handled?

ChartViewBase line 483

This doesn't actually solve the bug the original author intended. I feel like highlighting is messy right now, and we should reevaluate it in the future. We probably can just close this PR, but I'll let you decide.

ah I see. right a little messy. But why put lastHighlighted = h outside..
Why not just put both of them in
@objc open func highlightValue(_ highlight: Highlight?, callDelegate: Bool) with one line code?

I didn't want to make the change without evaluating the impact everywhere. I'm going to close this, and reevaluate highlighting at a later time.