Modify offsetForDrawing and draw method in BallonMarker swift#1741
Closed
oxape wants to merge 1 commit intoChartsOrg:masterfrom
oxape:master
Closed
Modify offsetForDrawing and draw method in BallonMarker swift#1741oxape wants to merge 1 commit intoChartsOrg:masterfrom oxape:master
oxape wants to merge 1 commit intoChartsOrg:masterfrom
oxape:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
=========================================
Coverage ? 18.68%
=========================================
Files ? 123
Lines ? 14052
Branches ? 0
=========================================
Hits ? 2626
Misses ? 11426
Partials ? 0Continue to review full report at Codecov.
|
Member
|
thanks @oxape! Please wait for a while as the review process could take time.. As you can see we are short handed and lots of questions and bugs to fix.. |
Collaborator
|
This is pretty. Can't wait to merge this :-) |
Author
|
I am very much looking forward |
Collaborator
|
Please rebase master |
Member
|
seems he deleted that branch.. |
Collaborator
|
I guess I'll reimplement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MarkerView can't indicate actual position of data.
Before
Now after modification.
