-
-
Notifications
You must be signed in to change notification settings - Fork 431
test: run against stable lighthouse release in sim tests #7973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7973 +/- ##
=========================================
Coverage 55.74% 55.74%
=========================================
Files 833 833
Lines 59383 59383
Branches 4581 4581
=========================================
+ Hits 33102 33105 +3
+ Misses 26214 26211 -3
Partials 67 67 🚀 New features to boost your workflow:
|
| # Use either image or local binary for the testing | ||
| GETH_BINARY_DIR= | ||
| LIGHTHOUSE_DOCKER_IMAGE=sigp/lighthouse:latest-amd64-unstable | ||
| LIGHTHOUSE_DOCKER_IMAGE=sigp/lighthouse:v7.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to do v7.0.1-amd64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
their image is multi arch, I am not exactly sure why we specifically used amd64 but this allows to run sim tests locally on any platform
Performance Report✔️ no performance regression detected Full benchmark results
|
) **Motivation** [Sim tests are failing](https://github.com/ChainSafe/lodestar/actions/runs/15706086864/job/44325974978) likely due to sigp/lighthouse#7444. It might be that Lighthouse drops support for pre-electra altogether so we need to see how to make that work with our multi fork sim tests. **Description** Run against stable lighthouse release in sim tests
|
🎉 This PR is included in v1.32.0 🎉 |
Motivation
Sim tests are failing likely due to sigp/lighthouse#7444. It might be that Lighthouse drops support for pre-electra altogether so we need to see how to make that work with our multi fork sim tests.
Description
Run against stable lighthouse release in sim tests