fix eth_get_filter_logs test #6363

sudo-shashank · 2025-12-18T07:25:08Z

Summary of changes

Changes introduced in this pull request:

fix test

Reference issue to close (if applicable)

Closes #5917

Change checklist

I have performed a self-review of my own code,
I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
I have added tests that prove my fix is effective or that my feature works (if possible),
I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

Tests
- Streamlined contract-invocation tests to use returned cids for waiting and log retrieval, improving reliability of transaction wait handling and filter-based log checks.
- Refined test builder behavior by replacing the public ignore modifier and tightening test naming/formatting.
- Adjusted filter construction and range handling for more consistent eth_get_filter_logs testing.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-18T07:25:16Z

Walkthrough

Switched test flows in stateful_tests.rs from manual message encoding/push and smsg-based waits to using invoke_contract which returns a CID; StateWaitMsg now waits on that CID. Removed explicit to_block in filter construction and removed the public ignore() usage for the eth_get_filter_logs test (renamed internal ignore to _ignore).

Changes

Cohort / File(s)	Summary
Stateful API tests `src/tool/subcommands/api_cmd/stateful_tests.rs`	Replaced manual payload encoding, MpoolPushMessage path and smsg wait with `invoke_contract` → CID return and `StateWaitMsg`-by-CID flow; removed explicit `to_block` field from `EthFilterSpec`; removed public `ignore()` usage on `eth_get_filter_logs` (introduced private `_ignore`); adjusted test registration formatting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Single-file change concentrated in test code.
Check: correctness of CID-based waiting vs previous smsg semantics; verify filter behavior without to_block; confirm _ignore visibility change doesn't break other test registrations.

Possibly related PRs

fix eth_newPendingTransactionFilter test #6361 — similar rewrite introducing invoke_contract and CID-based StateWaitMsg usage in the same test file.
fix(ci): ignore eth_newBlockFilter test in forest-tool api test-stateful #6070 — touches the test-builder/ignore() usage in stateful_tests.rs; closely related to the ignore handling changes.
Fix test for eth_newFilter creation #6104 — modifies test generation in stateful_tests.rs and the use/removal of ignore() in create_tests.

Suggested labels

RPC

Suggested reviewers

hanabi1224
LesnyRumcajs
akaladarshi

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix eth_get_filter_logs test' directly describes the main change in the pull request, which is fixing the failing eth_get_filter_logs test.
Linked Issues check	✅ Passed	The pull request addresses the requirements in issue #5917 by refactoring the eth_get_filter_logs test to use a cid-centric flow, removing the ignore modifier, and enabling the test to pass without being skipped.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the eth_get_filter_logs test in the stateful_tests.rs file, directly related to the linked issue #5917 with no out-of-scope modifications.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch shashank/get-filter-logs-test-fix

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe79ef and 4852965.

📒 Files selected for processing (1)

src/tool/subcommands/api_cmd/stateful_tests.rs (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/tool/subcommands/api_cmd/stateful_tests.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: Coverage
GitHub Check: Build forest binaries on Linux AMD64
GitHub Check: Build MacOS
GitHub Check: Build Ubuntu
GitHub Check: cargo-publish-dry-run
GitHub Check: tests-release
GitHub Check: All lint checks

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

LesnyRumcajs · 2025-12-18T13:15:02Z

no green checkmark, no review

codecov · 2025-12-18T14:16:16Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.75%. Comparing base (4628a7f) to head (3ee0550).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/tool/subcommands/api_cmd/stateful_tests.rs	0.00%	4 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
src/tool/subcommands/api_cmd/stateful_tests.rs	`0.00% <0.00%> (ø)`

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4628a7f...3ee0550. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sudo-shashank · 2025-12-18T14:17:46Z

no green checkmark, no review

@LesnyRumcajs ready for review now

fix eth_get_filter_logs

d048a8d

sudo-shashank added 2 commits December 18, 2025 13:12

Merge branch 'main' into shashank/get-filter-logs-test-fix

5a1b3f3

Merge branch 'main' into shashank/get-filter-logs-test-fix

9fe79ef

sudo-shashank marked this pull request as ready for review December 18, 2025 11:30

sudo-shashank requested a review from a team as a code owner December 18, 2025 11:30

sudo-shashank requested review from LesnyRumcajs and hanabi1224 and removed request for a team December 18, 2025 11:30

sudo-shashank enabled auto-merge December 18, 2025 11:31

lint fix

4852965

Merge branch 'main' into shashank/get-filter-logs-test-fix

3ee0550

LesnyRumcajs approved these changes Dec 19, 2025

View reviewed changes

sudo-shashank added this pull request to the merge queue Dec 19, 2025

Merged via the queue into main with commit 0c63421 Dec 19, 2025
43 checks passed

sudo-shashank deleted the shashank/get-filter-logs-test-fix branch December 19, 2025 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix eth_get_filter_logs test #6363

fix eth_get_filter_logs test #6363

sudo-shashank commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

LesnyRumcajs commented Dec 18, 2025

Uh oh!

codecov bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

sudo-shashank commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix eth_get_filter_logs test #6363

fix eth_get_filter_logs test #6363

Conversation

sudo-shashank commented Dec 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reference issue to close (if applicable)

Other information and links

Change checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

LesnyRumcajs commented Dec 18, 2025

Uh oh!

codecov bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sudo-shashank commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sudo-shashank commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

codecov bot commented Dec 18, 2025 •

edited

Loading