-
Notifications
You must be signed in to change notification settings - Fork 182
fix(ci): ignore eth_newBlockFilter test in forest-tool api test-stateful
#6070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA stateful test entry in src/tool/subcommands/api_cmd/stateful_tests.rs was reformatted to a multi-line builder chain and marked as ignored with a reference URL. No production code or public APIs were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches
🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/tool/subcommands/api_cmd/stateful_tests.rs (1)
109-120: Print the ignore reason and allow bypassing ignores in nightly runs.Two small improvements:
- Include the ignore message (URL) in the “ignored” log to aid triage.
- Gate ignores behind an env flag (e.g., FOREST_RUN_IGNORED=1) so we can exercise flaky tests in scheduled jobs.
Proposed tweak to run_tests logging/flow:
if let Some(reason) = test.ignore { if std::env::var_os("FOREST_RUN_IGNORED").is_none() { ignored += 1; println!( "test {} ... ignored: {reason}", if let Some(name) = test.name { name.to_string() } else { format!("#{i}") }, ); continue; } else { println!( "test {} ... RUNNING (was ignored): {reason}", if let Some(name) = test.name { name.to_string() } else { format!("#{i}") }, ); // fall through to run the test } }This keeps CI green by default while ensuring ignored tests still get signal in nightly/scheduled workflows.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/tool/subcommands/api_cmd/stateful_tests.rs(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: hanabi1224
PR: ChainSafe/forest#5930
File: build.rs:64-77
Timestamp: 2025-08-13T09:43:20.301Z
Learning: hanabi1224 prefers hard compile-time errors in build scripts rather than runtime safeguards or collision detection, believing it's better to fail fast and fix root causes of issues like malformed snapshot names.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: tests
- GitHub Check: tests-release
- GitHub Check: Build Ubuntu
- GitHub Check: cargo-publish-dry-run
- GitHub Check: Build MacOS
- GitHub Check: All lint checks
🔇 Additional comments (1)
src/tool/subcommands/api_cmd/stateful_tests.rs (1)
633-635: Scoped ignore is appropriate and consistent.Marking eth_newBlockFilter as ignored with a tracking link cleanly unblocks CI and follows the existing pattern used elsewhere in this file. No functional impact on production code.
Summary of changes
Ignore
eth_newBlockFiltertest to unblock CI, see #6069Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit