-
Notifications
You must be signed in to change notification settings - Fork 182
chore(deps): bump actions/download-artifact from 4 to 5 #6044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump actions/download-artifact from 4 to 5 #6044
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
WalkthroughBumps the GitHub Actions step in .github/workflows/forest.yml to use actions/download-artifact v5 instead of v4 for the forest-${{ runner.os }} artifact within the calibnet-api-test-stateful job. No other workflow logic or steps were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
.github/workflows/forest.yml (5)
394-398: Remove duplicate download step to cut runner time and I/O.This second actions/download-artifact@v5 call re-downloads the same artifact to the same path immediately after the previous step. It’s redundant and costs minutes.
Apply:
- - uses: actions/download-artifact@v5 - with: - name: "forest-${{ runner.os }}" - path: ~/.cargo/bin
147-155: Duplicate artifact download in calibnet-check.Two consecutive downloads of the same artifact to the same path. Remove one to save time.
- - uses: actions/download-artifact@v5 - with: - name: "forest-${{ runner.os }}" - path: ~/.cargo/bin
177-185: Duplicate artifact download in calibnet-stateless mode check.Same redundancy; safe to delete one.
- - uses: actions/download-artifact@v5 - with: - name: "forest-${{ runner.os }}" - path: ~/.cargo/bin
204-211: Duplicate artifact download in calibnet stateless RPC check.Remove the extra download.
- - uses: actions/download-artifact@v5 - with: - name: "forest-${{ runner.os }}" - path: ~/.cargo/bin
365-372: Duplicate artifact download in calibnet eth mapping check.Delete the redundant step.
- - uses: actions/download-artifact@v5 - with: - name: "forest-${{ runner.os }}" - path: ~/.cargo/bin
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/forest.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: tests-release
- GitHub Check: tests
- GitHub Check: All lint checks
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: Build Ubuntu
- GitHub Check: cargo-publish-dry-run
- GitHub Check: Build MacOS
🔇 Additional comments (2)
.github/workflows/forest.yml (2)
390-398: Bump to actions/download-artifact@v5 is safe here (download by name).You download a single artifact by name into a specific path, which retains the same extract-to-path behavior in v5. The v5 breaking change only affects single downloads by ID (now extracted directly to path instead of a nested subdir). No action needed. (github.com)
390-398: All download-artifact@v5 calls use thename/pathsyntax; noartifact-ids,pattern, ormerge-multiplekeys detected in any workflow.
Bumps actions/download-artifact from 4 to 5.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
634f93cMerge pull request #416 from actions/single-artifact-id-download-pathb19ff43refactor: resolve download path correctly in artifact download tests (mainly ...e262cbebundle distbff23f9update docsfff8c14fix download path logic when downloading a single artifact by id448e3f8Merge pull request #407 from actions/nebuk89-patch-147225c4Update README.mdDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit