-
Notifications
You must be signed in to change notification settings - Fork 182
chore(deps): bump actions/download-artifact from 4 to 5 #5950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump actions/download-artifact from 4 to 5 #5950
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
WalkthroughUpdated GitHub workflow steps to use actions/download-artifact@v5 instead of @v4. In docker.yml, two download steps were upgraded; in forest.yml, all occurrences were upgraded. No other parameters, steps, or control flow changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/forest.yml (2)
147-155: Duplicate download-artifact steps can be removedSeveral jobs have back-to-back identical downloads of the same artifact to the same path. This is redundant, costs time, and can mask errors. Remove the duplicates.
Apply removals like below for each duplicated block:
@@ - - uses: actions/download-artifact@v5 - with: - name: "forest-${{ runner.os }}" - path: ~/.cargo/bin @@ - - uses: actions/download-artifact@v5 - with: - name: "forest-${{ runner.os }}" - path: ~/.cargo/binAlso applies to: 177-185, 203-211, 387-394
444-446: Consider making download path explicit for consistencyThese steps omit the
pathinput. While current behavior is fine, setting a consistent explicit path improves readability and guards against future defaults drift.For example:
- uses: actions/download-artifact@v5 with: name: "forest-${{ runner.os }}" + path: ~/.cargo/binIf you prefer being explicit without relying on shell expansion, you can also use:
- path: ~/.cargo/bin + path: ${{ env.HOME }}/.cargo/binAlso applies to: 491-493, 528-530, 547-549, 573-575
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/docker.yml(1 hunks).github/workflows/forest.yml(18 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Build MacOS
- GitHub Check: Build Ubuntu
- GitHub Check: cargo-publish-dry-run
- GitHub Check: tests
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: tests-release
🔇 Additional comments (2)
.github/workflows/forest.yml (1)
125-129: Upgrade to actions/download-artifact@v5 is safe
Scanned all workflows under .github/workflows – every download uses the artifact name (with explicit path where applicable) and no artifact-id fields were found. No breaking-path changes; LGTM..github/workflows/docker.yml (1)
139-143: LGTM: v5 migration is safe hereThese steps download by name and target explicit directories. They’re unaffected by the v5 path change for ID-based downloads. No further changes needed.
Also applies to: 144-150
LesnyRumcajs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working fine.
Bumps actions/download-artifact from 4 to 5.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
634f93cMerge pull request #416 from actions/single-artifact-id-download-pathb19ff43refactor: resolve download path correctly in artifact download tests (mainly ...e262cbebundle distbff23f9update docsfff8c14fix download path logic when downloading a single artifact by id448e3f8Merge pull request #407 from actions/nebuk89-patch-147225c4Update README.mdDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit