src/tool/subcommands/archive_cmd.rs (1)

642-647: Early resource release is good; prefer scoping over explicit drop and enrich the error message

Explicitly dropping the store achieves the desired earlier release of mmap/FDs before re-opening the file via CarStream. Two minor improvements:

• Scope the store to a block instead of calling drop for clearer RAII and to avoid accidental future uses.
• Include the detected variant in the error message to aid debugging when a v2 snapshot is passed by mistake.

Apply this diff:

-    let store = AnyCar::try_from(filecoin.as_path())?;
-    anyhow::ensure!(
-        store.metadata().is_none(),
-        "The filecoin snapshot is not in v1 format"
-    );
-    drop(store);
+    {
+        let store = AnyCar::try_from(filecoin.as_path())?;
+        anyhow::ensure!(
+            store.metadata().is_none(),
+            "Input snapshot must be v1 (.car) without metadata; got variant {}",
+            store.variant()
+        );
+    } // drop store early

Additionally (outside this hunk), consider being explicit when creating the tokio file for the NamedTempFile to avoid any trait inference ambiguity:

// current:
let writer = tokio::io::BufWriter::new(tokio::fs::File::create(&temp_output).await?);

// suggested:
let writer = tokio::io::BufWriter::new(tokio::fs::File::create(temp_output.path()).await?);

interop-tests/src/tests/go_app/go.mod (1)

7-7: Dependency bumps LGTM; verify toolchain and transitive compatibility (libp2p/quic-go changes can be subtle)

The direct/indirect updates (boxo, libp2p stack, quic-go/webtransport, x/*, protobuf) look aligned. Action items to de-risk:

• Ensure CI images use Go ≥ 1.24.5 to match the module directive.
• libp2p v0.43.0 + DHT v0.34.0 and quic-go v0.54.0 sometimes tweak defaults (ALPN/token handling, congestion control). Please run interop tests against both IPv4/IPv6, NAT traversal, and QUIC transports.
• Run go mod tidy locally and commit go.sum changes to avoid CI drift.
• Keep an eye on webtransport-go v0.9.0 behavior if enabled in tests, as version skew with browsers/clients can surface flaky tests.

If you’d like, I can draft a checklist for targeted interop scenarios (QUIC, DHT bootstrapping, relay/NAT traversal) to run before merging.

Also applies to: 11-13, 53-53, 62-62, 90-90, 95-95, 103-105, 117-121, 123-127

f3-sidecar/go.mod (1)

6-6: go-f3 pseudo-version bump and networking stack upgrades: confirm runtime compatibility and plan to migrate to a tag

• Pinning to go-f3 pseudo-version (v0.8.10-0.20250813...) is fine to pull perf improvements now; consider switching to the next official tag once cut to improve reproducibility.
• The libp2p/quic-go/pion updates mirror the interop test app. Validate end-to-end flows (pubsub, DHT, QUIC) and confirm no regressions in connection manager or resource manager tuning.
• Ensure the CI builder uses Go ≥ 1.24.5. Commit updated go.sum after a tidy.

When a stable go-f3 tag containing the perf PR lands, I can prep a follow-up PR to pin to it and remove the pseudo-version.

Also applies to: 14-15, 18-18, 24-24, 45-45, 56-56, 65-65, 72-72, 82-83, 96-96, 101-101, 110-111, 128-136, 138-138

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: hanabi1224
PR: ChainSafe/forest#5930
File: build.rs:64-77
Timestamp: 2025-08-13T09:43:20.301Z
Learning: hanabi1224 prefers hard compile-time errors in build scripts rather than runtime safeguards or collision detection, believing it's better to fail fast and fix root causes of issues like malformed snapshot names.

Learnt from: hanabi1224
PR: ChainSafe/forest#5886
File: src/daemon/db_util.rs:236-259
Timestamp: 2025-08-11T14:00:47.060Z
Learning: In Forest's snapshot import (`src/daemon/db_util.rs`), when F3 CID is present in snapshot metadata but the actual F3 data is missing, this should cause a hard error as it indicates snapshot corruption. Only errors during the F3 import process itself (after data is successfully retrieved) should be non-fatal and logged.