chore(deps): bump go-f3 and Go deps #5881
Conversation
WalkthroughDependency versions were updated in the Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to dependency version updates. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
f3-sidecar/go.mod (1)
23-40: Rungo mod tidyafter the mass indirect-version bump
Several dozen transitive versions were lifted. Atidywill trim any now-orphaned constraints and refreshgo.sum, preventing future CI drift.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
f3-sidecar/go.sumis excluded by!**/*.suminterop-tests/src/tests/go_app/go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
f3-sidecar/go.mod(5 hunks)interop-tests/src/tests/go_app/go.mod(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: tests
- GitHub Check: tests-release
- GitHub Check: All lint checks
- GitHub Check: cargo-publish-dry-run
- GitHub Check: Build MacOS
- GitHub Check: Build Ubuntu
- GitHub Check: Analyze (rust)
- GitHub Check: Analyze (go)
🔇 Additional comments (3)
f3-sidecar/go.mod (1)
6-14: Confirm downstream code compiles against the bumped direct deps
go-f3 v0.8.9,rust2gotip,go-log/v2 v2.8.0, and libp2p v0.42.x all shipped minor API tweaks (e.g. new functional options in libp2p, renamed log levels in go-log). Please run a full build / test sweep and vendor update to catch latent breakages before merge.interop-tests/src/tests/go_app/go.mod (2)
6-14: Ensure interop module stays lock-step with sidecar for core deps
The test harness now pulls the samerust2go,go-log/v2, andlibp2pversions as the sidecar. Good ✅ — just make sure no other module in the repo still references older tags, otherwisego mod graphwill drag them back in.
26-33: Chanqueue & deque upgrades can alter blocking semantics
gammazero/chanqueue 1.1.xfixed a starvation edge-case by changing default buffer sizing. If the interop tests rely on specific channel depths, double-check for timing regressions.
| golang.org/x/crypto v0.40.0 // indirect | ||
| golang.org/x/exp v0.0.0-20250718183923-645b1fa84792 // indirect | ||
| golang.org/x/mod v0.26.0 // indirect | ||
| golang.org/x/net v0.42.0 // indirect | ||
| golang.org/x/sync v0.16.0 // indirect | ||
| golang.org/x/sys v0.34.0 // indirect | ||
| golang.org/x/text v0.27.0 // indirect | ||
| golang.org/x/time v0.12.0 // indirect | ||
| golang.org/x/tools v0.34.0 // indirect | ||
| golang.org/x/tools v0.35.0 // indirect |
There was a problem hiding this comment.
Go tool-chain on CI must be ≥ 1.24.5
Both modules declare go 1.24.5. Verify your builders and Docker images have been bumped; otherwise the updated std-lib constraints will fail in CI.
🤖 Prompt for AI Agents
In interop-tests/src/tests/go_app/go.mod around lines 121 to 129, ensure that
the Go toolchain version used in your CI environment, builders, and Docker
images is updated to at least 1.24.5 to match the module's declared Go version.
Verify and update the Go version in all relevant CI configurations and
Dockerfiles to prevent standard library compatibility issues during builds.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
@LesnyRumcajs CI uses Go version defined in go.work so it's fine. cc @coderabbitai
go 1.24.5
use (
./f3-sidecar
./interop-tests/src/tests/go_app
)
- uses: actions/setup-go@v5
with:
go-version-file: "go.work"There was a problem hiding this comment.
@hanabi1224 are you sure? there were failures around it over the weekend #5866
There was a problem hiding this comment.
@LesnyRumcajs The Dockerfile needs to be updated manually indeed, but this PR does not bump the Go toolchain.
Summary of changes
Changes introduced in this pull request:
go-f3Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit