Skip to content

Remove noisy prints #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elmattic merged 4 commits into from
Aug 6, 2025
Merged

Remove noisy prints #5903

elmattic merged 4 commits into from
Aug 6, 2025

Conversation

@elmattic
Copy link
Contributor

@elmattic elmattic commented Aug 6, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

  • Refactor index backfill to use tracing instead of prints
  • Remove populate_eth_mappings function

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Refactor

    • Unified and streamlined the database backfill process for Ethereum-related mappings, consolidating functionality and improving logging for better traceability.
    • Removed outdated synchronous methods and updated documentation to reflect enhanced support for both Event and Ethereum RPC APIs.

  • Style

    • Improved logging granularity by adjusting log levels and replacing print statements with structured tracing.

  • Chores

    • Cleaned up unused imports and removed obsolete function calls to maintain code clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025 •
edited
Loading

Walkthrough

The changes remove the synchronous populate_eth_mappings function, consolidate its logic into the asynchronous backfill_db function with enhanced logging, and update documentation accordingly. Related imports and calls to the removed function are deleted. Additionally, some log levels are adjusted for more granular tracing.

Changes

Cohort / File(s) Change Summary
Chain Store Logging
src/chain/store/chain_store.rs		 Changed log level from debug to trace for the message reporting the number of entries written in the Ethereum mapping within process_signed_messages.
DB Backfill Refactor & Logging
src/daemon/db_util.rs		 Removed the synchronous populate_eth_mappings function. Consolidated its logic into the async backfill_db function, which now has enhanced logging, tracks backfill count, and updated documentation. Unused imports were removed.
Offline Server Cleanup
src/tool/offline_server/server.rs		 Removed import and usage of the deleted populate_eth_mappings function in the offline server startup logic.

Sequence Diagram(s)

sequenceDiagram
    participant Server as Offline Server
    participant DBUtil as db_util.rs
    participant StateMgr as StateManager

    Server->>DBUtil: backfill_db(state_manager, head_ts, to_epoch)
    DBUtil->>StateMgr: (iterate and backfill mappings)
    DBUtil-->>Server: Log backfill progress and completion
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Suggested reviewers

  • sudo-shashank

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75f97d8 and 47c55ca.

📒 Files selected for processing (1)
  • src/daemon/db_util.rs (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/daemon/db_util.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: All lint checks
  • GitHub Check: Build MacOS
  • GitHub Check: Build Ubuntu
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: Analyze (rust)
  • GitHub Check: Analyze (go)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch elmattic/remove-print-noise
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@elmattic elmattic added the RPC requires calibnet RPC checks to run on CI label Aug 6, 2025
@elmattic elmattic marked this pull request as ready for review August 6, 2025 10:01
@elmattic elmattic requested a review from a team as a code owner August 6, 2025 10:01
@elmattic elmattic requested review from LesnyRumcajs and sudo-shashank and removed request for a team August 6, 2025 10:01
@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Aug 6, 2025

no green checkmark 👉 no review ❌

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Aug 6, 2025

Nice. I actually wanted to complain about it before. 🤣

@elmattic elmattic added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 4c7816d Aug 6, 2025
43 checks passed
@elmattic elmattic deleted the elmattic/remove-print-noise branch August 6, 2025 14:30
sudo-shashank pushed a commit that referenced this pull request Aug 11, 2025
@elmattic @sudo-shashank
Remove noisy prints (#5903)
1043640
@coderabbitai coderabbitai bot mentioned this pull request Sep 11, 2025
Merged
4 tasks
@coderabbitai coderabbitai bot mentioned this pull request Sep 29, 2025
Merged
4 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 13, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@sudo-shashank sudo-shashank sudo-shashank approved these changes

Assignees

No one assigned

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elmattic @LesnyRumcajs @sudo-shashank