OneDrive Addon [#OSF-8573]#7653
Merged
sloria merged 6 commits intoCenterForOpenScience:developfrom Nov 21, 2017
Merged
Conversation
e474bb5 to
96dc357
Compare
aeb6649 to
0a63f74
Compare
* these are already handled in the base class (ExternalAccount)
[#OSF-8573]
0a63f74 to
855bd10
Compare
sloria
reviewed
Nov 21, 2017
| folder_path = models.TextField(null=True, blank=True) | ||
| user_settings = models.ForeignKey(UserSettings, null=True, blank=True) | ||
|
|
||
| _api = None |
Contributor
There was a problem hiding this comment.
Shouldn't this be an instance attribute rather than a class attribute? Wouldn't OneDriveProvider instances be shared if this is a class attribute?
sloria
reviewed
Nov 21, 2017
| except exceptions.InvalidAuthError: | ||
| raise HTTPError(403) | ||
|
|
||
| oneDriveClient = OneDriveClient(access_token) |
Contributor
There was a problem hiding this comment.
Minor: should be onedrive_client.
sloria
reviewed
Nov 21, 2017
| var $osf = require('js/osfHelpers'); | ||
|
|
||
| // Cross browser key codes for the Command key | ||
| var commandKeys = [224, 17, 91, 93]; |
Contributor
There was a problem hiding this comment.
This doesn't appear to be used.
sloria
reviewed
Nov 21, 2017
|
|
||
| class TestCore(unittest.TestCase): | ||
|
|
||
| def setUp(self): |
Contributor
There was a problem hiding this comment.
Minor: pytest fixtures should be used in favor of unittest.
sloria
reviewed
Nov 21, 2017
|
|
||
| var m = require('mithril'); | ||
| var $ = require('jquery'); | ||
| var URI = require('URIjs'); |
Contributor
There was a problem hiding this comment.
Minor: there are a number of unused imports here.
sloria
approved these changes
Nov 21, 2017
Contributor
sloria
left a comment
There was a problem hiding this comment.
Looks good. Just nits; I'll take care of those when I merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Updates #7042
Changes
Side effects
WARNING: Possible migration collision
If the other addon PRs go in, migrations will need to be recreated, not just merged
Ticket
[OSF-8573]