[SVCS-269] Add readonly provider for OneDrive [skip-ci]#7042
Closed
felliott wants to merge 64 commits intoCenterForOpenScience:develop-backupfrom
Closed
[SVCS-269] Add readonly provider for OneDrive [skip-ci]#7042felliott wants to merge 64 commits intoCenterForOpenScience:develop-backupfrom
felliott wants to merge 64 commits intoCenterForOpenScience:develop-backupfrom
Conversation
…ere with wiring up onedrive
…todo:refresh access token and get folder list
…sh and getting auth token
…h folder selection
…ntents out of onedrive
…Error messages - BuildError: ('JSONRenderer__onedrive_oauth_start_user', {}, None)
* these are already handled in the base class (ExternalAccount)
* onedrive_id => folder_id, folder_id => folder_path, folder_name is computed from folder_path
* remove OneDriveNodeSettings.has_auth * not sure why, but it was recommended * let ODNodeSettings.clear_auth unset the user settings * add clear_settings to ODNodeSettings * remove ODNodeSettings.set_user_auth as unneeded, it duplicates .set_auth()
* remove methods with base implementation from OD serializer * make addon_short_name a class variable instead of a property * factor out custom code from serialize_settings and use base instead * move custom code into credentials_are_valid and serialized_folder
* remove unused share emails view * repoint routes to new views
* copy GDrive's creds_are_valid code * update view names passed to api_url_for
* It didn't need to stand alone.
* make root folder id configurable * enable externalView * finish proper handling of folder picker * add more method docs with API doc links
* Being unexportable means they cannot be archived, downloaded, viewed, or copied.
99b745d to
5e33f5e
Compare
Member
|
Closing in favor of #7653 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add support for a read-only OneDrive provider to the OSF.
Changes
Backs out write support in 178cd42.
Side effects
Will need to be Django-fied.
Ticket
[#SVCS-269] - JIRA
Entangled with WB PR: CenterForOpenScience/waterbutler#205
Based off work done by @caseyrygt, @dsterlaceGT, and @alexandr-melnikov-dev-pro in PRs #6589 and #4681.