[Feature] Bitbucket Addon [OSF-8192]#7409
Merged
sloria merged 3 commits intoCenterForOpenScience:release/next-djangolefrom Jul 10, 2017
Merged
[Feature] Bitbucket Addon [OSF-8192]#7409sloria merged 3 commits intoCenterForOpenScience:release/next-djangolefrom
sloria merged 3 commits intoCenterForOpenScience:release/next-djangolefrom
Conversation
8ec048d to
f2aa17c
Compare
mfraezz
commented
Jun 30, 2017
| if changed: | ||
|
|
||
| # # Delete existing hook, if any | ||
| # node_settings.delete_hook() |
Member
Author
There was a problem hiding this comment.
Note: Bitbucket does support webhooks, but Services/Product teams opted to skip them in the short term to release this faster. Comments left to simplify adding in future
19f0592 to
90023fb
Compare
felliott
added a commit
to CenterForOpenScience/waterbutler
that referenced
this pull request
Jul 3, 2017
* Add readonly support for Bitbucket to WaterButler. At the time this was being developed, Bitbucket did not have a write API, but that has since changed[1]. Write support will be added in a future ticket. This addon will not be useable until the corresponding OSF PR (CenterForOpenScience/osf.io#7409) is merged. Tickets: [SVCS-238][SVCS-266][SVCS-268][SVCS-376] Closes: #198 [1] https://bitbucket.org/site/master/issues/8672/is-there-any-api-to-make-a-commit-bb-9954
Member
|
The corresponding WB PR has been merged and pushed to WB's |
f2936d9 to
7138348
Compare
7138348 to
6e8ed33
Compare
sloria
suggested changes
Jul 7, 2017
website/static/js/logTextParser.js
Outdated
|
|
||
| bitbucket_repo: { | ||
| view: function(ctrl, logObject) { | ||
| var bitbucket_user = logObject.attributes.params.bitbucket_user; |
Contributor
There was a problem hiding this comment.
Minor: as per the style guidelines, use lowerCameCase for variable names.
I'm aware that the github code is inconsistent--that can be changed another day...
6e8ed33 to
2d7794f
Compare
2d7794f to
f521b9a
Compare
Member
Author
|
@sloria , finagling complete. |
sloria
approved these changes
Jul 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #6954
MIGRATION WARNING
Not only does this share a migration number (
0042) with #7418 , that migration has a conflicting action -- altering possible types forBaseFileNode.Running
makemigrations --mergewill NOT be sufficient.Instead, whichever PR goes in last will need the migration recreated before being merged.