Skip to content

Tenant controller logic - only call create network when necessary#1291

Merged
centaurus-cloud-bot merged 4 commits intoCentaurusInfra:masterfrom
Sindica:tenant-controller-logic
Jan 21, 2022
Merged

Tenant controller logic - only call create network when necessary#1291
centaurus-cloud-bot merged 4 commits intoCentaurusInfra:masterfrom
Sindica:tenant-controller-logic

Conversation

@Sindica
Copy link
Collaborator

@Sindica Sindica commented Jan 21, 2022 •
edited
Loading

Previous tenant controller resync every 5 min. Each time it will try to create arktos network and silently fail if object already exists.

The correct logic is check existence from informer lister before create action.

Before change, API server get POST arktos.futurewei.com request from each tenant every 5 min:

ubuntu@ip-172-30-0-14:~/go/src/k8s.io/arktos$ cat /tmp/kube-apiserver0.log | grep POST | grep arktos.futurewei.com | grep aaa
I0121 02:53:02.732248   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (4.197716ms) 201 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]
I0121 02:55:47.761874   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (2.726653ms) 409 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]
I0121 03:00:47.763127   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (3.632425ms) 409 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]
I0121 03:05:47.764969   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (5.367067ms) 409 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]
I0121 03:10:47.763120   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (3.225313ms) 409 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]
I0121 03:15:47.763202   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (2.916273ms) 409 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]
I0121 03:20:47.763869   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (3.472108ms) 409 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]
I0121 03:25:47.764305   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (3.627087ms) 409 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]
I0121 03:30:47.765303   10439 wrap.go:47] POST /apis/arktos.futurewei.com/v1/tenants/aaa/networks: (4.444155ms) 409 [hyperkube/v0.9.0 (linux/amd64) kubernetes/$Format/system:serviceaccount:kube-system:tenant-controller 172.30.0.14:60436]

After change, there is only one POST arktos.futurewei.com request for each tenant

This PR fix issue #1256

yb01
yb01 reviewed Jan 21, 2022
View reviewed changes
yb01
yb01 approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@yb01 yb01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Jan 21, 2022

/LGTM

@zmn223
Copy link
Collaborator

zmn223 commented Jan 21, 2022

/approve

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yb01, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot centaurus-cloud-bot merged commit 25f4c81 into CentaurusInfra:master Jan 21, 2022
Sindica added a commit that referenced this pull request Jan 21, 2022
@Sindica
Tenant controller logic - only call create network when necessary (#1291
549c8da 
)

* Rename consolidation actions in tenant controller

* Only call create network when necessary

* Minor changes

* Remove misleading log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yb01 yb01 yb01 approved these changes

@h-w-chen h-w-chen Awaiting requested review from h-w-chen

@q131172019 q131172019 Awaiting requested review from q131172019

Assignees

@yb01 yb01

@zmn223 zmn223

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sindica @zmn223 @centaurus-cloud-bot @yb01