bug fix: kubeclientmgr.Pick should be concurrent safe#1209
Merged
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom Oct 8, 2021
Merged
Conversation
yb01
reviewed
Oct 8, 2021
|
|
||
| func (manager *KubeClientManager) PickClient(tenant string) int { | ||
| manager.tenant2apiLock.RLock() | ||
| defer manager.tenant2apiLock.RUnlock() |
Collaborator
There was a problem hiding this comment.
the purpose of the fix is to reduce the lock window, if so, let's explicitly call RUnlock() after the map read.
Collaborator
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: q131172019, zmn223 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, could you invite me to arktos slack channel? Thanks. |
click2cloud-amit
pushed a commit
to Click2Cloud-Centaurus/arktos
that referenced
this pull request
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a subtle defect caused by code change to kubeclientmanager (original code did not have such bug).
Pick method was exposed public; however access to its internal shared data is not guarded properly with the exposure.
Does this PR introduce a user-facing change?:
NONE