feat(test-tests): add eip-7708 eth transfer log tests and framework support#2
Merged
Carsons-Eels merged 11 commits intoJan 22, 2026
Conversation
marioevz
reviewed
Jan 16, 2026
marioevz
left a comment
Collaborator
There was a problem hiding this comment.
Left some comments, thanks!
marioevz
reviewed
Jan 19, 2026
marioevz
left a comment
Collaborator
There was a problem hiding this comment.
More comments for more test ideas!
4a88e25 to
1d2ffbf
Compare
e57d4c2 to
f2619e5
Compare
17 tasks
Collaborator
Author
|
Addressed spec changes and updated according to the EIPs repo changes. Added some more tests. Missing tests are documented here: ethereum#1875 (comment) Will add them in a follow-up PR! |
7284896 to
bb8d7ab
Compare
180ef09 to
0919c7d
Compare
0919c7d to
cee7f5f
Compare
5d9a44d to
bf16746
Compare
cee7f5f to
f89c00d
Compare
Carsons-Eels
approved these changes
Jan 22, 2026
Carsons-Eels
left a comment
Owner
There was a problem hiding this comment.
Had to fix one minor thing, other than that looks great. Thank you ❤️
Carsons-Eels
pushed a commit
that referenced
this pull request
Mar 10, 2026
…arison (ethereum#2407) * feat: split code for easier testing + add unit test * test(test-execute): add JSONRPCError fallback path test for nonce sync. (#2) - Cover the try/except branch in sync_worker_key_nonce() where get_account with block_number="latest" raises JSONRPCError and the function falls back to "pending". - The existing parametrized tests only exercise the happy path; this completes branch coverage for the extracted function. - Not parametrized because the nonce-sync logic is already proven by the existing cases — this test's concern is the recovery path. --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is rebased on top of
forks/amsterdam, and will be rebased back on top ofCarsons-Eels/eips/amsterdam/eip-7708once it is rebased on top offorks/amsterdam. This is to check the tests fill on BAL.Specs Changes
Tries to address: ethereum#2023 (comment)
Adds selfdestruct emit log (log2) and the
SELFDESTRUCT_TOPIC.Test Filling
The PR add some initial tests and framework changes to fill, please fill with:
Future Tests
ethereum#1875 (comment)