Undefined variable error may sometimes occur when dealing with RRD output#5773
Closed
MSS970 wants to merge 1 commit intoCacti:developfrom
Closed
Undefined variable error may sometimes occur when dealing with RRD output#5773MSS970 wants to merge 1 commit intoCacti:developfrom
MSS970 wants to merge 1 commit intoCacti:developfrom
Conversation
Update rrd.php missing variable $okpos
Member
|
Can you redo this for 1.2.x branch or is it fine there? |
Contributor
Author
|
I have been using Cacti 1.3 (Dev) for long time on Windows and did not test this issue on 1.2.x |
Contributor
Author
|
I presume it is the same issue in Cacti 1.2.x, just checked the 1.2.x branch: function rrdtool_trim_output(&$output) { /* MSS: missing variable here */ |
TheWitness
added a commit
that referenced
this pull request
Jun 20, 2024
Member
|
Okay, I fixed this in 1.2.x and will cherry pick into 1.3 shortly. |
TheWitness
added a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update rrd.php missing variable $okpos