When upgrading database at command line, some PHP errors may be seen#5012
Merged
TheWitness merged 2 commits intoCacti:1.2.xfrom Nov 20, 2022
Merged
When upgrading database at command line, some PHP errors may be seen#5012TheWitness merged 2 commits intoCacti:1.2.xfrom
TheWitness merged 2 commits intoCacti:1.2.xfrom
Conversation
Contributor
ddb4github
commented
Nov 20, 2022
- Fixed: get_rrdtool_version report str_replace error if rrdtool_version does not exist
- Fixed: move global static $phperrors before other error-able function call
- Fixed: file_exists report error if path_spine is not configured
…n does not exist Fixed: move global static $phperrors before other error-able function call Fixed: file_exists report error if path_spine is not configured
Member
|
Looks good @ddb4github ! |
Member
|
Can you amend a CHANGELOG for this. Just use the pull request #. |
Member
|
Note the one minor change for PHP5.4 @ddb4github |
Member
|
Just going to merge. I'll get the CHANGELOG updated |
TheWitness
added a commit
that referenced
this pull request
Nov 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.