Skip to content

Improve PHP 8.1 support for Installer CLI#4738

Merged
TheWitness merged 1 commit intoCacti:1.2.xfrom
ddb4github:fixaudit
Nov 24, 2022
Merged

Improve PHP 8.1 support for Installer CLI#4738
TheWitness merged 1 commit intoCacti:1.2.xfrom
ddb4github:fixaudit

Conversation

@ddb4github
Copy link
Copy Markdown
Contributor

@ddb4github ddb4github commented Apr 24, 2022

No description provided.

@ddb4github
Copy link
Copy Markdown
Contributor Author

ddb4github commented Apr 24, 2022 •
edited
Loading 

CMDPHP PHP ERROR Backtrace:  (/cli/audit_database.php[125]:repair_database(), /cli/audit_database.php[315]:report_audit_results(), /cli/audit_database.php[498]:str_replace(), CactiErrorHandler())
ERROR PHP DEPRECATED: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in file: /var/www/html/cacti/cli/audit_database.php  on line: 497
CMDPHP PHP ERROR Backtrace:  (/cli/audit_database.php[125]:repair_database(), /cli/audit_database.php[315]:report_audit_results(), /cli/audit_database.php[497]:str_replace(), CactiErrorHandler())
ERROR PHP DEPRECATED: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in file: /var/www/html/cacti/cli/audit_database.php  on line: 498
CMDPHP PHP ERROR Backtrace:  (/cli/audit_database.php[125]:repair_database(), /cli/audit_database.php[315]:report_audit_results(), /cli/audit_database.php[498]:str_replace(), CactiErrorHandler())

@ddb4github ddb4github changed the title More fix for #4079 to avoid PHP 8.0 error Update three fiels for PHP 8.x error Apr 24, 2022
netniV
netniV reviewed Apr 24, 2022
View reviewed changes
@netniV netniV added this to the v1.2.21 milestone Apr 29, 2022
@netniV netniV closed this Apr 29, 2022
@ddb4github
Copy link
Copy Markdown
Contributor Author

ddb4github commented Nov 24, 2022

Just check Cacti 1.2.x branch, this PR is not merged

@ddb4github ddb4github changed the title Update three fiels for PHP 8.x error Update three files for PHP 8.x error Nov 24, 2022
@TheWitness TheWitness reopened this Nov 24, 2022
@TheWitness
Copy link
Copy Markdown
Member

TheWitness commented Nov 24, 2022

Reopened.

@TheWitness TheWitness changed the title Update three files for PHP 8.x error CLI Based upgrade generates warnings in PHP 8.1 Nov 24, 2022
@TheWitness TheWitness merged commit 5efe3f2 into Cacti:1.2.x Nov 24, 2022
TheWitness added a commit that referenced this pull request Nov 24, 2022
@TheWitness
Updating ChangLog for #4738
45d2801
@ddb4github ddb4github deleted the fixaudit branch December 1, 2022 02:58
@netniV netniV changed the title CLI Based upgrade generates warnings in PHP 8.1 Improve PHP 8.1 support for Installer CLI Dec 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@netniV netniV netniV approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.2.21

Development

Successfully merging this pull request may close these issues.

3 participants

@ddb4github @TheWitness @netniV